[BUG] git config: cygwin git version 1.6.1.2 does not deletes empty sections

[BUG] git config: cygwin git version 1.6.1.2 does not deletes empty sections

[Constantine Plotnikov]

I have encountered a bug related to git config in cygwin git version 1.6.1.2

The git config --unset might leave an empty section when the last
property is deleted. But consequent "git config key value" does not
uses this empty section. So the following script leaves a sequence of
empty sections "[a]". Looks like a disk space leak to me.

git config a.b a
git config --unset a.b
git config a.b a
git config --unset a.b
git config a.b a
git config --unset a.b
git config a.b a
git config --unset a.b

The resulting .git/config file:

[core]
	repositoryformatversion = 0
	filemode = true
	bare = false
	logallrefupdates = true
	ignorecase = true
[a]
[a]
[a]
[a]

Was this bug fixed in later versions?

Constantine

Re: [BUG] git config: cygwin git version 1.6.1.2 does not deletes empty sections

[Constantine Plotnikov]

The bug is also confirmed on MSYS git version 1.6.2.2.1669.g7eaf8.

Constantine

On Wed, May 6, 2009 at 7:50 PM, Constantine Plotnikov
<constantine.plotnikov@gmail.com> wrote:
> I have encountered a bug related to git config in cygwin git version 1.6.1.2
>
> The git config --unset might leave an empty section when the last
> property is deleted. But consequent "git config key value" does not
> uses this empty section. So the following script leaves a sequence of
> empty sections "[a]". Looks like a disk space leak to me.
>
> git config a.b a
> git config --unset a.b
> git config a.b a
> git config --unset a.b
> git config a.b a
> git config --unset a.b
> git config a.b a
> git config --unset a.b
>
> The resulting .git/config file:
>
> [core]
>        repositoryformatversion = 0
>        filemode = true
>        bare = false
>        logallrefupdates = true
>        ignorecase = true
> [a]
> [a]
> [a]
> [a]
>
> Was this bug fixed in later versions?
>
> Constantine
>

Re: [BUG] git config: cygwin git version 1.6.1.2 does not deletes empty sections

[Erik Faye-Lund]

On Wed, May 6, 2009 at 6:04 PM, Constantine Plotnikov
<constantine.plotnikov@gmail.com> wrote:
> The bug is also confirmed on MSYS git version 1.6.2.2.1669.g7eaf8.

The same issue is present in git 1.6.2.1 on Linux. Not that I'm too
sure it's really a bug, though ;)

-- 
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656

Re: [BUG] git config: cygwin git version 1.6.1.2 does not deletes empty sections

[Michał Kiedrowicz]

Erik Faye-Lund <kusmabite@googlemail.com> wrote:

> On Wed, May 6, 2009 at 6:04 PM, Constantine Plotnikov
> <constantine.plotnikov@gmail.com> wrote:
> > The bug is also confirmed on MSYS git version 1.6.2.2.1669.g7eaf8.
> 
> The same issue is present in git 1.6.2.1 on Linux. Not that I'm too
> sure it's really a bug, though ;)
> 

Happens also in master (v1.6.3-rc4-29-g8146f19). IMO this is because
git_parse_file() reports only *variables*, not *sections* and
store_aux() doesn't find empty section.

--
Michał Kiedrowicz