git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philip Oakley <philipoakley@iee.email>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Shourya Shukla <shouryashukla.oo@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com,
	gitster@pobox.com, liu.denton@gmail.com,
	kaartic.sivaraam@gmail.com, pc44800@gmail.com,
	sbeller@google.com, pclouds@gmail.com,
	Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 1/4] submodule: amend extra line feed between callback struct and macro
Date: Fri, 3 Jul 2020 16:37:06 +0100	[thread overview]
Message-ID: <8a36a3cd-02a3-f4fa-7b86-0d4884c88449@iee.email> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2007031653570.50@tvgsbejvaqbjf.bet>


Suggestion...

On 03/07/2020 15:57, Johannes Schindelin wrote:
> Maybe a native reader can suggest something that flows a bit easier? I am
> not a native English speaker, but I'd prefer something along those lines:
>
> 	Many `submodule--helper` subcommands follow the convention a
s/convention a/convention that a/    feels nicer for me
> 	struct defines their callback data, and the declaration of said
s/said/that/   maybe.  'said' is a bit too much like 'patent speak', but
otherwise either word is OK.
> 	struct is followed immediately by a macro to use in static
> 	initializers, without any separating empty line.
>
> 	Let's align the `init`, `status` and `sync` subcommands with that
> 	convention.
Nice summary.

Philip
Native Yorkshire speaker, but not that 'literate' ;-)

  reply	other threads:[~2020-07-03 15:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 19:24 [GSoC][PATCH 0/4] submodule: port 'summary' from Shell to C Shourya Shukla
2020-07-02 19:24 ` [PATCH 1/4] submodule: amend extra line feed between callback struct and macro Shourya Shukla
2020-07-03 14:57   ` Johannes Schindelin
2020-07-03 15:37     ` Philip Oakley [this message]
2020-07-04 15:21       ` Shourya Shukla
2020-07-04 15:39         ` Đoàn Trần Công Danh
2020-07-05 10:52           ` Philip Oakley
2020-07-02 19:24 ` [PATCH 2/4] submodule: rename helper functions to avoid ambiguity Shourya Shukla
2020-07-02 19:24 ` [PATCH 3/4] diff: change scope of the function count_lines() Shourya Shukla
2020-07-03 15:07   ` Johannes Schindelin
2020-07-04 15:28     ` Shourya Shukla
2020-07-04 21:46       ` Christian Couder
2020-07-02 19:24 ` [PATCH 4/4] submodule: port submodule subcommand 'summary' from shell to C Shourya Shukla
2020-07-03 20:46   ` Johannes Schindelin
2020-07-05 17:34     ` Shourya Shukla
2020-07-06  9:16       ` Kaartic Sivaraam
2020-07-06 11:15         ` Shourya Shukla
2020-07-12  0:46           ` Johannes Schindelin
2020-07-15 14:53             ` Shourya Shukla
2020-07-15 18:41               ` Shourya Shukla
2020-08-10 13:24                 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a36a3cd-02a3-f4fa-7b86-0d4884c88449@iee.email \
    --to=philipoakley@iee.email \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=liu.denton@gmail.com \
    --cc=pc44800@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=sbeller@google.com \
    --cc=shouryashukla.oo@gmail.com \
    --subject='Re: [PATCH 1/4] submodule: amend extra line feed between callback struct and macro' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).