From: Derrick Stolee <stolee@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Cc: "Jeff King" <peff@peff.net>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v4 12/12] t5318: use test_oid for HASH_LEN
Date: Tue, 4 Sep 2018 08:36:11 -0400 [thread overview]
Message-ID: <8af735dc-99cd-f297-415f-24e53ea77344@gmail.com> (raw)
In-Reply-To: <20180903232515.336397-13-sandals@crustytoothpaste.net>
On 9/3/2018 7:25 PM, brian m. carlson wrote:
> From: Derrick Stolee <stolee@gmail.com>
>
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> t/t5318-commit-graph.sh | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh
> index 3c1ffad491..d286516f0e 100755
> --- a/t/t5318-commit-graph.sh
> +++ b/t/t5318-commit-graph.sh
> @@ -8,7 +8,8 @@ test_expect_success 'setup full repo' '
> cd "$TRASH_DIRECTORY/full" &&
> git init &&
> git config core.commitGraph true &&
> - objdir=".git/objects"
> + objdir=".git/objects" &&
> + test_oid_init
> '
Ah yes, thanks for adding this.
>
> test_expect_success 'verify graph with no graph file' '
> @@ -273,7 +274,7 @@ test_expect_success 'git commit-graph verify' '
>
> NUM_COMMITS=9
> NUM_OCTOPUS_EDGES=2
> -HASH_LEN=20
> +HASH_LEN="$(test_oid rawsz)"
> GRAPH_BYTE_VERSION=4
> GRAPH_BYTE_HASH=5
> GRAPH_BYTE_CHUNK_COUNT=6
next prev parent reply other threads:[~2018-09-04 12:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 23:25 [PATCH v4 00/12] Hash-independent tests (part 3) brian m. carlson
2018-09-03 23:25 ` [PATCH v4 01/12] t: add test functions to translate hash-related values brian m. carlson
2018-09-04 0:01 ` Eric Sunshine
2018-09-05 22:50 ` brian m. carlson
2018-09-03 23:25 ` [PATCH v4 02/12] t0000: use hash translation table brian m. carlson
2018-09-03 23:25 ` [PATCH v4 03/12] t0000: update tests for SHA-256 brian m. carlson
2018-09-03 23:25 ` [PATCH v4 04/12] t0002: abstract away SHA-1 specific constants brian m. carlson
2018-09-03 23:25 ` [PATCH v4 05/12] t0027: make hash size independent brian m. carlson
2018-09-03 23:25 ` [PATCH v4 06/12] t0064: " brian m. carlson
2018-09-03 23:25 ` [PATCH v4 07/12] t1006: " brian m. carlson
2018-09-03 23:25 ` [PATCH v4 08/12] t1400: switch hard-coded object ID to variable brian m. carlson
2018-09-03 23:25 ` [PATCH v4 09/12] t1405: make hash size independent brian m. carlson
2018-09-03 23:25 ` [PATCH v4 10/12] t1406: make hash-size independent brian m. carlson
2018-09-03 23:25 ` [PATCH v4 11/12] t1407: make hash size independent brian m. carlson
2018-09-03 23:25 ` [PATCH v4 12/12] t5318: use test_oid for HASH_LEN brian m. carlson
2018-09-04 12:36 ` Derrick Stolee [this message]
2018-09-04 16:22 ` [PATCH v4 00/12] Hash-independent tests (part 3) Duy Nguyen
2018-09-04 19:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8af735dc-99cd-f297-415f-24e53ea77344@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).