From: Eric Sunshine <sunshine@sunshineco.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "Git List" <git@vger.kernel.org>, "Jeff King" <peff@peff.net>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"Derrick Stolee" <stolee@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v4 01/12] t: add test functions to translate hash-related values
Date: Mon, 3 Sep 2018 20:01:35 -0400 [thread overview]
Message-ID: <CAPig+cQZMEvJZ2b3RjtXvy9ZtTjRKUvye_xT0nibOqcHtpApZQ@mail.gmail.com> (raw)
In-Reply-To: <20180903232515.336397-2-sandals@crustytoothpaste.net>
On Mon, Sep 3, 2018 at 7:25 PM brian m. carlson
<sandals@crustytoothpaste.net> wrote:
> Add several test functions to make working with various hash-related
> values easier.
> [...]
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> @@ -1155,3 +1155,70 @@ depacketize () {
> +# Detect the hash algorithm in use.
> +test_detect_hash () {
> + test_hash_algo='sha1'
> +}
Not worth a re-roll itself, but if you do re-roll for some reason,
perhaps include a comment inside the function saying that the actual
"detect" part will be fleshed out later.
> +test_oid_cache () {
> + local tag reset k v
s/reset/rest/
It probably wouldn't hurt to &&-chain the above, as well, to
future-proof it against someone coming along and inserting code before
the 'local' line.
> + test -n "$test_hash_algo" || test_detect_hash &&
> + while read tag rest
> + do
> + case $tag in
> + [...]
> + esac &&
> +
> + k="${rest%:*}" &&
> + v="${rest#*:}" &&
> +
> + if ! expr "$k" : '[a-z0-9][a-z0-9]*$' >/dev/null
> + then
> + error 'bug in the test script: bad hash algorithm'
Did you want to redirect this to stderr like you do with error() in test_oid()?
> + fi &&
> + eval "test_oid_${k}_$tag=\"\$v\""
> + done
> +}
next prev parent reply other threads:[~2018-09-04 0:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 23:25 [PATCH v4 00/12] Hash-independent tests (part 3) brian m. carlson
2018-09-03 23:25 ` [PATCH v4 01/12] t: add test functions to translate hash-related values brian m. carlson
2018-09-04 0:01 ` Eric Sunshine [this message]
2018-09-05 22:50 ` brian m. carlson
2018-09-03 23:25 ` [PATCH v4 02/12] t0000: use hash translation table brian m. carlson
2018-09-03 23:25 ` [PATCH v4 03/12] t0000: update tests for SHA-256 brian m. carlson
2018-09-03 23:25 ` [PATCH v4 04/12] t0002: abstract away SHA-1 specific constants brian m. carlson
2018-09-03 23:25 ` [PATCH v4 05/12] t0027: make hash size independent brian m. carlson
2018-09-03 23:25 ` [PATCH v4 06/12] t0064: " brian m. carlson
2018-09-03 23:25 ` [PATCH v4 07/12] t1006: " brian m. carlson
2018-09-03 23:25 ` [PATCH v4 08/12] t1400: switch hard-coded object ID to variable brian m. carlson
2018-09-03 23:25 ` [PATCH v4 09/12] t1405: make hash size independent brian m. carlson
2018-09-03 23:25 ` [PATCH v4 10/12] t1406: make hash-size independent brian m. carlson
2018-09-03 23:25 ` [PATCH v4 11/12] t1407: make hash size independent brian m. carlson
2018-09-03 23:25 ` [PATCH v4 12/12] t5318: use test_oid for HASH_LEN brian m. carlson
2018-09-04 12:36 ` Derrick Stolee
2018-09-04 16:22 ` [PATCH v4 00/12] Hash-independent tests (part 3) Duy Nguyen
2018-09-04 19:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cQZMEvJZ2b3RjtXvy9ZtTjRKUvye_xT0nibOqcHtpApZQ@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=stolee@gmail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).