From: Isaac Hier <isaachier@gmail.com>
To: Stephan Beyer <s-beyer@gmx.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH 0/1] Implement CMake build
Date: Wed, 24 Jan 2018 21:16:44 -0500 [thread overview]
Message-ID: <CAG6xkCZK+Vda=Mtpy665tiGZ_FpXzUaz__w+FFpfE+zZioRX2Q@mail.gmail.com> (raw)
In-Reply-To: <e3d1e1f4-9927-47eb-7662-2c6918555058@gmx.net>
Stephan, I totally agree about the advanced options. At first, I left
them as visible options seeing as the Makefile does not comment which
are advanced and which are basic.
In terms of the up-to-dateness, I find it easier to "fast-forward" all
the changes at once without tangling myself in a load of periodic
updates.
On Wed, Jan 24, 2018 at 5:02 PM, Stephan Beyer <s-beyer@gmx.net> wrote:
> On 01/24/2018 10:19 PM, Isaac Hier wrote:
>> Thanks for your interest! This patch is based on the cmake-build
>> branch of https://github.com/isaachier/git, but the full history is on
>> the cmake branch (squashed it for easier readability). Hope that
>> helps.
>
> Thanks. I use the cmake branch because I prefer "real" history over one
> huge commit.
>
> And I already love it. Thanks for all the work!
>
> From a first short glance, I wonder if you should mark a lot more
> options as advanced options, like the paths (e.g., SHELL_PATH,
> LESS_PATH, GETTEXT_MSGFMT_EXECUTABLE, etc.) and probably also things
> like GIT_USER_AGENT. If you use a configuration tool like ccmake, you
> see a lot of options and many of them are not relevant to the average user.
>
> I also think some variables have weird names, for example, POLL, PREAD,
> MMAP should be USE_POLL, USE_PREAD, USE_MMAP, respectively... or even
> USE_*_SYSCALL, I don't know.
>
> By the way, regarding up-to-dateness, you are missing these recent
> changes that have been merged to master:
>
> edb6a17c36 Makefile: NO_OPENSSL=1 should no longer imply BLK_SHA1=1
> 3f824e91c8 t/Makefile: introduce TEST_SHELL_PATH
>
> (which is not surprising)
>
> ~Stephan
next prev parent reply other threads:[~2018-01-25 2:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 0:16 [RFC PATCH 0/1] Implement CMake build Isaac Hier
2018-01-23 0:16 ` [RFC PATCH 1/1] " Isaac Hier
2018-01-24 13:45 ` [RFC PATCH 0/1] " Isaac Hier
2018-01-24 18:11 ` Jacob Keller
2018-01-24 18:47 ` Junio C Hamano
2018-01-24 20:53 ` Ævar Arnfjörð Bjarmason
2018-01-24 21:15 ` Stephan Beyer
2018-01-24 21:19 ` Isaac Hier
2018-01-24 22:02 ` Stephan Beyer
2018-01-25 2:16 ` Isaac Hier [this message]
2018-01-24 19:36 ` Jeff Hostetler
2018-01-24 19:59 ` Isaac Hier
2018-01-24 21:00 ` Jeff Hostetler
2018-01-24 21:17 ` Isaac Hier
2018-01-26 0:21 ` Isaac Hier
2018-01-26 17:34 ` Jeff Hostetler
2018-02-20 16:28 ` Robert Dailey
2018-02-23 18:48 ` Isaac Hier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG6xkCZK+Vda=Mtpy665tiGZ_FpXzUaz__w+FFpfE+zZioRX2Q@mail.gmail.com' \
--to=isaachier@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=s-beyer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).