From: Isaac Hier <isaachier@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Isaac Hier <isaachier@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH 0/1] Implement CMake build
Date: Wed, 24 Jan 2018 08:45:03 -0500 [thread overview]
Message-ID: <CAG6xkCZn6m2n0rDvpN6MmZcOr2hJBRCfhrppC37f-DUj3_JZsw@mail.gmail.com> (raw)
In-Reply-To: <20180123001648.24260-1-isaachier@gmail.com>
I realize this is a huge patch, but does anyone have feedback for the
general idea?
On Mon, Jan 22, 2018 at 7:16 PM, Isaac Hier <isaachier@gmail.com> wrote:
> This patch adds a mostly complete (aside from building tests, documentation,
> installation, etc.) CMake build to the git project. I am not sure how much
> interest there is in a CMake build, so please send me feedback one way or
> another. Personally, I believe CMake will help with Windows builds and is
> somewhat easier to read than a Makefile. I considered, adding this to the
> contrib directory, but CMakeLists.txt almost always reside in the original
> directories, and I'm not sure how wise it would be to do otherwise. If you are
> interested in a CMake build, I would be more than happy to finish up the work
> here. Decided to wait until I discussed the issue here to finish the final parts
> of the build.
>
> Isaac Hier (1):
> Implement CMake build
>
> CMakeLists.txt | 1849 +++++++++++++++++++++++++++++++++++++++++++
> cmake/GenerateCmdlist.cmake | 83 ++
> cmake/fopen_dir_test.c | 11 +
> cmake/fstat_test.c | 37 +
> cmake/gmtime_test.c | 7 +
> cmake/iconv_test.c | 13 +
> cmake/inline_test.c | 9 +
> cmake/mkdir_test.c | 7 +
> cmake/mmap_test.c | 35 +
> cmake/parens_test.c | 6 +
> cmake/snprintf_test.c | 7 +
> cmake/sysctl_test.c | 11 +
> 12 files changed, 2075 insertions(+)
> create mode 100644 CMakeLists.txt
> create mode 100644 cmake/GenerateCmdlist.cmake
> create mode 100644 cmake/fopen_dir_test.c
> create mode 100644 cmake/fstat_test.c
> create mode 100644 cmake/gmtime_test.c
> create mode 100644 cmake/iconv_test.c
> create mode 100644 cmake/inline_test.c
> create mode 100644 cmake/mkdir_test.c
> create mode 100644 cmake/mmap_test.c
> create mode 100644 cmake/parens_test.c
> create mode 100644 cmake/snprintf_test.c
> create mode 100644 cmake/sysctl_test.c
>
> --
> 2.14.1
>
next prev parent reply other threads:[~2018-01-24 13:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 0:16 [RFC PATCH 0/1] Implement CMake build Isaac Hier
2018-01-23 0:16 ` [RFC PATCH 1/1] " Isaac Hier
2018-01-24 13:45 ` Isaac Hier [this message]
2018-01-24 18:11 ` [RFC PATCH 0/1] " Jacob Keller
2018-01-24 18:47 ` Junio C Hamano
2018-01-24 20:53 ` Ævar Arnfjörð Bjarmason
2018-01-24 21:15 ` Stephan Beyer
2018-01-24 21:19 ` Isaac Hier
2018-01-24 22:02 ` Stephan Beyer
2018-01-25 2:16 ` Isaac Hier
2018-01-24 19:36 ` Jeff Hostetler
2018-01-24 19:59 ` Isaac Hier
2018-01-24 21:00 ` Jeff Hostetler
2018-01-24 21:17 ` Isaac Hier
2018-01-26 0:21 ` Isaac Hier
2018-01-26 17:34 ` Jeff Hostetler
2018-02-20 16:28 ` Robert Dailey
2018-02-23 18:48 ` Isaac Hier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG6xkCZn6m2n0rDvpN6MmZcOr2hJBRCfhrppC37f-DUj3_JZsw@mail.gmail.com \
--to=isaachier@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).