Re: [PATCH v2 1/2] Add project-wide .vimrc configuration

From: Felipe Contreras <felipe.contreras@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
	Felipe Contreras <felipe.contreras@gmail.com>,
	Git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
	Jeff King <peff@peff.net>,
	Emily Shaffer <emilyshaffer@google.com>,
	Aaron Schrab <aaron@schrab.com>,
	Denton Liu <liu.denton@gmail.com>,
	Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH v2 1/2] Add project-wide .vimrc configuration
Date: Thu, 10 Dec 2020 19:08:00 -0600	[thread overview]
Message-ID: <CAMP44s33J6F60W=2Yd2WSGE78VT0XBkewi8m3unXvathBH2TOQ@mail.gmail.com> (raw)
In-Reply-To: <X9GbIG9vZbK1pEoi@camp.crustytoothpaste.net>

On Wed, Dec 9, 2020 at 9:51 PM brian m. carlson
<sandals@crustytoothpaste.net> wrote:
> On 2020-12-09 at 06:55:36, Felipe Contreras wrote:

> I don't think this should go in this location.  It should go in contrib.
> Here's why:
>
> * We should not ship editor-specific files in the main directory of the
>   repository.

Why not?

>   Even though Vim is very popular, it is one of many
>   editors, and it is not even the most popular editor (which is now VS
>   Code).

Even if vim is not the most popular, it certainly is among the top 3
(and I doubt VS Code is the most popular, I would like to see some
numbers on that, but even then; VS Code is not an editor).

Nobody is arguing to have editor-specific files for "every editor
under the sun", just perhaps 2 (or maybe even 3).

No slippery slope fallacy here.

>   We have editor-independent files, and users can copy this into
>   the root of the repository and ignore it if they want it there.

Which are insufficient. They are certainly better than nothing. Plus,
it's unclear how many people are actually using those.

And I'm still waiting for the argument against adding such a top-level file.

What is the harm?

> * Whether a user wants to use automatic indentation is a personal
>   preference.  I do happen to like it, but there are others who don't
>   and prefer to leave it off.  Similarly, whether to use cindent,
>   smartindent, or autoindent is a preference, as is which cindent
>   options to use (I use different ones).

So?

These options will not be forced on users, they have to specifically
enable them by doing at least two steps, *and* they can still
selectively override them in their ~/.vim files.

> * These settings affect every file that's loaded in the same editor
>   process.

That is not true.

:setlocal [1] applies the setting to the current buffer only, not
globally, and *only* when the buffer is of the filetype specified in
the autocommand.

> So while I agree that these are common settings, they are not
> universally applicable, even for Vim and Neovim users, and we shouldn't
> try to claim that all or even most Vim and Neovim users should use them.

We don't. These are defaults, which a) the user must consciously
choose to apply them, and b) can be easily overridden (as is explained
in the commit message).

> So I think contrib makes more sense here.

Clearly. But you haven't put forward an argument about how precisely
will this negatively affect *any* user (or the project).

Cheers.

[1] https://vimhelp.org/options.txt.html#%3Asetlocal

-- 
Felipe Contreras