Re: [PATCH v4] submodule: port subcommand 'set-url' from shell to C

From: Christian Couder <christian.couder@gmail.com>
To: Shourya Shukla <shouryashukla.oo@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	chrisitan.couder@gmail.com, Denton Liu <liu.denton@gmail.com>,
	git <git@vger.kernel.org>
Subject: Re: [PATCH v4] submodule: port subcommand 'set-url' from shell to C
Date: Fri, 8 May 2020 08:18:57 +0200	[thread overview]
Message-ID: <CAP8UFD0=_8D8hkT5VVPV_F++dr131bkjby357fA+QfhQxktcMg@mail.gmail.com> (raw)
In-Reply-To: <20200508054728.GA8615@konoha>

On Fri, May 8, 2020 at 7:51 AM Shourya Shukla
<shouryashukla.oo@gmail.com> wrote:
>
> On 06/05 10:08, Junio C Hamano wrote:

> > Specifically, I would write "!path", not "path == NULL".  I thought
> > a rule for that is in the CodingGuidelines (I didn't double check,
> > though).
>
> I could not find a rule like that in the CodingGuidelines.
> Should I add it?
> https://github.com/git/git/blob/master/Documentation/CodingGuidelines

Sure.

> > The comparison on argc is to see if we are even allowed to access
> > argv[0] and/or argv[1].  In practice, if what main() got from the
> > outside world in argv[] is passed directly to you, argv[n] would
> > never be NULL as long as n < argc, but there are a few levels of
> > callchain between main() and you (i.e. module_set_url()), so not
> > counting on that would be sensible.
>
> Understood. I will add the NULL check as well.

Thanks,
Christian.