Re: [PATCH v5] submodule: port subcommand 'set-url' from shell to C

From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Shourya Shukla <shouryashukla.oo@gmail.com>,
	christian.couder@gmail.com, git@vger.kernel.org,
	kaartic.sivaraam@gmail.com
Subject: Re: [PATCH v5] submodule: port subcommand 'set-url' from shell to C
Date: Fri, 08 May 2020 09:17:22 -0700	[thread overview]
Message-ID: <xmqqh7wqz9il.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200508063022.GA18557@generichostname> (Denton Liu's message of "Fri, 8 May 2020 02:30:22 -0400")

Denton Liu <liu.denton@gmail.com> writes:

>> +	if (argc != 2 || !path || !newurl) {
>> +		usage_with_options(usage, options);
>> +		return 1;

It is embarrassing that nobody noticed that usage_with_options() is
NORETURN; return 1 has no effect here.

>> +	}
>> +
>> +	config_name = xstrfmt("submodule.%s.url", path);
>> +
>> +	config_set_in_gitmodules_file_gently(config_name, newurl);
>> +	sync_submodule(path, prefix, quiet ? OPT_QUIET : 0);
>> +
>> +	free(config_name);
>> +
>> +	return 0;
>> +}
>> +
>>  #define SUPPORT_SUPER_PREFIX (1<<0)
>>  
>>  struct cmd_struct {