From: Jubilee Young <email@example.com> To: firstname.lastname@example.org Cc: email@example.com, Jonathan Tan <firstname.lastname@example.org>, Christian Couder <email@example.com>, firstname.lastname@example.org Subject: Re: [PATCH v7 1/1] Implement rev-list --bisect* --first-parent Date: Wed, 6 Nov 2019 21:07:06 -0800 [thread overview] Message-ID: <CAPNHn3oCOQRriDLmLFag0DWgvq2t3TLMiu25HyBKcuBuwLgb2g@mail.gmail.com> (raw) In-Reply-To: <email@example.com> Hi! Thanks for all the feedback. On Wed, Nov 6, 2019 at 1:36 PM Jonathan Tan <firstname.lastname@example.org> wrote: > > > > Also, clarify in the commit message somewhere that this commit does not > > > change the behavior of "git bisect". > > > > s/\.$/ when used without the "--first-parent" option&/; you mean? > > As far as I know, "git bisect" doesn't support --first-parent, whether > before or after this patch. Correct, it still provides the usual "usage: git bisect ..." error. This provides plumbing but no porcelain right now. > At first I thought that this patch also teaches "git bisect" to support > "--first-parent", but that is not the case. Only "git rev-list" learns > to make "--bisect" work with "--first-parent". So I wanted the > clarification. (But if you think that the clarification is unnecessary, > that's fine too.) I had been trying to deduce the best approach for writing the commit message but in the end I retained a hunch that I didn't yet know enough to write the best one so this conversation is quite illuminating re: commit style. If it's even slightly confusing I would like to clarify, since bisect.c and git bisect are... very different! I think Dscho's recommendation also will result in the patch overall being far more lucid.
next prev parent reply other threads:[~2019-11-07 5:07 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-05 5:21 [Outreachy] [PATCH v7 0/1] Revenge of --bisect --first-parent workingjubilee 2019-11-05 5:21 ` [PATCH v7 1/1] Implement rev-list --bisect* --first-parent workingjubilee 2019-11-05 23:04 ` Jonathan Tan 2019-11-06 2:42 ` Junio C Hamano 2019-11-06 11:30 ` Johannes Schindelin 2019-11-06 21:36 ` Jonathan Tan 2019-11-07 3:35 ` Junio C Hamano 2019-11-07 5:07 ` Jubilee Young [this message] 2019-11-07 16:00 ` Jubilee Young 2019-11-07 18:56 ` Jonathan Tan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPNHn3oCOQRriDLmLFag0DWgvq2t3TLMiu25HyBKcuBuwLgb2g@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v7 1/1] Implement rev-list --bisect* --first-parent' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).