Re: [PATCH 2/6] t/lib-bitmap.sh: avoid silencing stderr

[Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>]

On Sat, Aug 20, 2022 at 3:00 AM Taylor Blau <me@ttaylorr.com> wrote:
>
> The midx_bitmap_partial_tests() function is responsible for setting up a
> state where some (but not all) packs in the repository are covered by a
> MIDX (and bitmap).
>
> This function has redirected the `git multi-pack-index write --bitmap`'s
> stderr to a file "err" since its introduction back in c51f5a6437 (t5326:
> test multi-pack bitmap behavior, 2021-08-31).
>
> This was likely a stray change left over from a slightly different
> version of this test, since the file "err" is never read after being
> written. This leads to confusingly-missing output, especially when the
> contents of stderr are important.
>
> Resolve this confusion by avoiding silencing stderr in this case.
>
> Signed-off-by: Taylor Blau <me@ttaylorr.com>
> ---
>  t/lib-bitmap.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/lib-bitmap.sh b/t/lib-bitmap.sh
> index a95537e759..f595937094 100644
> --- a/t/lib-bitmap.sh
> +++ b/t/lib-bitmap.sh
> @@ -440,7 +440,7 @@ midx_bitmap_partial_tests () {
>                 test_commit packed &&
>                 git repack &&
>                 test_commit loose &&
> -               git multi-pack-index write --bitmap 2>err &&
> +               git multi-pack-index write --bitmap &&
>                 test_path_is_file $midx &&
>                 test_path_is_file $midx-$(midx_checksum $objdir).bitmap
>         '

Thanks Taylor! I would say this is a very good change. It might have
been there for some reason when it was written, but that was resisting
us to debug what was going on ;-)