git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlo Arenas <carenas@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Victoria Dye via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, gitster@pobox.com, philipoakley@iee.email,
	eschwartz@archlinux.org, Jeff King <peff@peff.net>,
	Victoria Dye <vdye@github.com>
Subject: Re: [PATCH v2] async_die_is_recursing: work around GCC v11.x issue on Fedora
Date: Thu, 4 Nov 2021 02:46:02 -0700	[thread overview]
Message-ID: <CAPUEspiJW8ee_1zoMg6JzJ0ow-2tmPh8iUZK41kfvt6etzEfjQ@mail.gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2111040823270.56@tvgsbejvaqbjf.bet>

On Thu, Nov 4, 2021 at 1:43 AM Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:

> My best guess is that my GCC (which is v11.2.0) and Fedora's GCC (which is
> v11.2.1 plus the usual Fedora customization) behave slightly differently
> with respect to that optional `size-index` argument:
> `pthread_setspecific()` is essentially declared without a `size-index`, so
> I guess GCC v11.2.1 probably defaults to `size-index = 1`.

Got to read the whole explanation that Victoria put together.

for the warning to trigger on that gcc, you got also to have the
attribute in the header as shown by the link[1] she provided, and
which I am sure could be a nice thing to send toward those helpful
folks of the MSYS2 project so it can be added to their WinPthread
headers, as was done in glibc.

Carlo

[1] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=a1561c3bbe8

  reply	other threads:[~2021-11-04  9:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04  1:47 [PATCH] async_die_is_recursing: fix use of pthread_getspecific for Fedora Victoria Dye via GitGitGadget
2021-11-04  2:23 ` Carlo Arenas
2021-11-04  2:37   ` Jeff King
2021-11-04  3:20     ` Carlo Arenas
2021-11-04  5:56       ` Jeff King
2021-11-04  4:01 ` [PATCH v2] async_die_is_recursing: work around GCC v11.x issue on Fedora Victoria Dye via GitGitGadget
2021-11-04  5:58   ` Jeff King
2021-11-04  6:35   ` Junio C Hamano
2021-11-04  9:42     ` Ævar Arnfjörð Bjarmason
2021-11-04 13:08       ` Derrick Stolee
2021-11-04 17:46         ` Junio C Hamano
2021-11-05 21:45     ` Junio C Hamano
2021-11-04  8:43   ` Johannes Schindelin
2021-11-04  9:46     ` Carlo Arenas [this message]
2021-11-04 16:33       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPUEspiJW8ee_1zoMg6JzJ0ow-2tmPh8iUZK41kfvt6etzEfjQ@mail.gmail.com \
    --to=carenas@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=eschwartz@archlinux.org \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=philipoakley@iee.email \
    --cc=vdye@github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).