From: Jeff King <peff@peff.net>
To: Carlo Arenas <carenas@gmail.com>
Cc: Victoria Dye via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, gitster@pobox.com, philipoakley@iee.email,
eschwartz@archlinux.org, Victoria Dye <vdye@github.com>
Subject: Re: [PATCH] async_die_is_recursing: fix use of pthread_getspecific for Fedora
Date: Thu, 4 Nov 2021 01:56:10 -0400 [thread overview]
Message-ID: <YYN1+tonXZgL9dDa@coredump.intra.peff.net> (raw)
In-Reply-To: <CAPUEspjnu8ySiM5damzCoPWhLv+azZFxsZun5Lztjwd-fDopaw@mail.gmail.com>
On Wed, Nov 03, 2021 at 08:20:56PM -0700, Carlo Arenas wrote:
> Agree it is OK as a minimal fix, but also AFAIK nothing is really
> stuck either, so something as simple as :
>
> s/&ret/&async_die_counter/g
>
> Would make it as minimal, and less likely to trigger something else in
> the future (I am surprised nothing warns about local variables being
> used out of scope).
It's in scope when we call the function. The potential for bugs only
happens because we know pthread_setspecific() is going to hold on to
it. So the compiler complaining would imply that it knows the semantics
of the pthread function.
-Peff
next prev parent reply other threads:[~2021-11-04 5:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 1:47 [PATCH] async_die_is_recursing: fix use of pthread_getspecific for Fedora Victoria Dye via GitGitGadget
2021-11-04 2:23 ` Carlo Arenas
2021-11-04 2:37 ` Jeff King
2021-11-04 3:20 ` Carlo Arenas
2021-11-04 5:56 ` Jeff King [this message]
2021-11-04 4:01 ` [PATCH v2] async_die_is_recursing: work around GCC v11.x issue on Fedora Victoria Dye via GitGitGadget
2021-11-04 5:58 ` Jeff King
2021-11-04 6:35 ` Junio C Hamano
2021-11-04 9:42 ` Ævar Arnfjörð Bjarmason
2021-11-04 13:08 ` Derrick Stolee
2021-11-04 17:46 ` Junio C Hamano
2021-11-05 21:45 ` Junio C Hamano
2021-11-04 8:43 ` Johannes Schindelin
2021-11-04 9:46 ` Carlo Arenas
2021-11-04 16:33 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYN1+tonXZgL9dDa@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=carenas@gmail.com \
--cc=eschwartz@archlinux.org \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=philipoakley@iee.email \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).