From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ed Maste <emaste@freebsd.org>,
git mailing list <git@vger.kernel.org>,
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
Eric Wong <e@80x24.org>
Subject: Re: [PATCH v3] sparse-checkout: improve OS ls compatibility
Date: Fri, 20 Dec 2019 13:34:36 -0500 [thread overview]
Message-ID: <CAPig+cQ29dEbQgnJmGvODy9kGYq9TqKaJV5-mOPXbGFZ1HRWmw@mail.gmail.com> (raw)
In-Reply-To: <xmqqftheamea.fsf@gitster-ct.c.googlers.com>
On Fri, Dec 20, 2019 at 1:21 PM Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
> > anomalous behavior is still present. It would be helpful, therefore,
> > to mention such an implementation by name:
> >
> > ...some 'ls' implementations, such as on FreeBSD, include...
> >
> If we _were_ to add an in-code comment, we may want to say something
> like
>
> # Do not replace this with "cd "$1" && ls", as FreeBSD "ls"
> # enables "-A" when run by root without being told, and ends
> # up including ".git" etc. in its output.
>
> to warn future developers against improving and/or cleaning up.
I would find this comment more helpful than the existing one since it
spells out the issue precisely. A minor tweak:
# Do not replace this with "cd "$1" && ls", as FreeBSD "ls"
# enables "-A" by default when run by root, and ends up
# including ".git" etc. in its output.
> Not that we encourage running our tests as root, though. I am
> slightly worried that the above phrasing might be taken as such.
I'm not sure we really need to spell it out, but something like this
might allay that concern:
# Do not replace this with "cd "$1" && ls", as FreeBSD "ls"
# enables "-A" by default when run by root, and ends up
# including ".git" etc. in its output. (Note, though, that
# running the test suite as root is generally not
# recommended.)
next prev parent reply other threads:[~2019-12-20 18:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 1:58 [PATCH] sparse-checkout: improve OS ls compatibility Ed Maste
2019-12-19 2:07 ` Derrick Stolee
2019-12-19 2:18 ` Ed Maste
2019-12-19 2:22 ` Derrick Stolee
2019-12-19 2:45 ` Eric Wong
2019-12-19 13:56 ` Derrick Stolee
2019-12-19 16:15 ` Ed Maste
2019-12-19 16:34 ` Derrick Stolee
2019-12-19 18:11 ` Junio C Hamano
2019-12-19 20:56 ` Ed Maste
2019-12-19 22:01 ` Junio C Hamano
2019-12-19 21:45 ` [PATCH v2] " Ed Maste
2019-12-19 22:27 ` Denton Liu
2019-12-20 15:38 ` [PATCH v3] " Ed Maste
2019-12-20 16:05 ` Derrick Stolee
2019-12-20 17:55 ` Junio C Hamano
2019-12-20 17:55 ` Eric Sunshine
2019-12-20 18:15 ` Ed Maste
2019-12-20 18:21 ` Junio C Hamano
2019-12-20 18:34 ` Eric Sunshine [this message]
2019-12-20 18:34 ` Ed Maste
2019-12-20 19:23 ` Junio C Hamano
2019-12-20 19:33 ` Eric Sunshine
2019-12-20 19:41 ` [PATCH v4] " Ed Maste
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cQ29dEbQgnJmGvODy9kGYq9TqKaJV5-mOPXbGFZ1HRWmw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=e@80x24.org \
--cc=emaste@freebsd.org \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).