From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Heba Waly via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>, Heba Waly <heba.waly@gmail.com>
Subject: Re: [PATCH v2 1/1] commit: display advice hints when commit fails
Date: Thu, 19 Dec 2019 14:47:49 -0500 [thread overview]
Message-ID: <CAPig+cQZBXOZeYDJRH+9YLobTOP1_UndV_Snk+S0_LL1=h-aag@mail.gmail.com> (raw)
In-Reply-To: <xmqqbls4aznl.fsf@gitster-ct.c.googlers.com>
On Thu, Dec 19, 2019 at 2:22 PM Junio C Hamano <gitster@pobox.com> wrote:
> In any case, here is what I tentatively have in my tree (with heavy
> rewrite to the proposed log message).
>
> +test_expect_success 'commit without staging files fails and displays hints' '
> + echo "initial" >>file &&
The use of '>>' here rather than '>' feels wrong, especially when
"initial" is used for both the file body and the commit message,
causing a reader of the test to wonder if this test somehow depends
upon earlier tests.
> + git add file &&
> + git commit -m initial &&
> + echo "changes" >>file &&
> + test_must_fail git commit -m update >actual &&
> + test_i18ngrep "no changes added to commit (use \"git add\" and/or \"git commit -a\")" actual
> +'
next prev parent reply other threads:[~2019-12-19 19:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 9:17 [PATCH 0/1] [Outreachy] commit: display advice hints when commit fails Heba Waly via GitGitGadget
2019-12-17 9:17 ` [PATCH 1/1] " Heba Waly via GitGitGadget
2019-12-17 22:41 ` Junio C Hamano
2019-12-17 22:45 ` Emily Shaffer
2019-12-19 3:47 ` Heba Waly
2019-12-18 3:13 ` Jonathan Tan
2019-12-18 18:14 ` Junio C Hamano
2019-12-19 3:48 ` Heba Waly
2019-12-19 9:16 ` [PATCH v2 0/1] [Outreachy] " Heba Waly via GitGitGadget
2019-12-19 9:16 ` [PATCH v2 1/1] " Heba Waly via GitGitGadget
2019-12-19 19:14 ` Junio C Hamano
2019-12-19 19:22 ` Junio C Hamano
2019-12-19 19:47 ` Eric Sunshine [this message]
2019-12-19 19:57 ` Junio C Hamano
2019-12-20 2:31 ` Emily Shaffer
2019-12-20 18:34 ` Junio C Hamano
2019-12-20 21:39 ` Emily Shaffer
2019-12-31 0:04 ` Jonathan Tan
2019-12-31 19:06 ` Junio C Hamano
2020-01-02 19:56 ` Jonathan Tan
2019-12-19 18:26 ` [PATCH v2 0/1] [Outreachy] " Junio C Hamano
2019-12-19 18:54 ` Emily Shaffer
2019-12-19 19:23 ` Junio C Hamano
2019-12-19 19:45 ` Junio C Hamano
2019-12-21 4:37 ` Heba Waly
2019-12-21 23:54 ` Junio C Hamano
2019-12-21 5:02 ` Heba Waly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cQZBXOZeYDJRH+9YLobTOP1_UndV_Snk+S0_LL1=h-aag@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=heba.waly@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).