git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heba Waly via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Heba Waly <heba.waly@gmail.com>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/1] [Outreachy] commit: display advice hints when commit fails
Date: Tue, 17 Dec 2019 09:17:21 +0000	[thread overview]
Message-ID: <pull.495.git.1576574242.gitgitgadget@gmail.com> (raw)

Display hints to the user when trying to commit without staging the modified
files first (when advice.statusHints is set to true). Change the output of
the unsuccessful commit from e.g:

[...]
=====

Changes not staged for commit:
==============================

modified: builtin/commit.c
==========================

 #

no changes added to commit
==========================

to:

[...]
=====

Changes not staged for commit:
==============================

(use "git add ..." to update what will be committed)
====================================================

(use "git checkout -- ..." to discard changes in working directory)
===================================================================

 #

modified: ../builtin/commit.c
=============================

 #

no changes added to commit (use "git add" and/or "git commit -a")
=================================================================

In ea9882bfc4 (commit: disable status hints when writing to COMMIT_EDITMSG,
2013-09-12) the intent was to disable status hints when writing to
COMMIT_EDITMSG, but in fact the implementation disabled status messages in
more locations, e.g in case the commit wasn't successful, status hints will
still be disabled and no hints will be displayed to the user although
advice.statusHints is set to true.

Signed-off-by: Heba Waly heba.waly@gmail.com [heba.waly@gmail.com]

Heba Waly (1):
  commit: display advice hints when commit fails

 builtin/commit.c                          | 1 +
 t/t7500-commit-template-squash-signoff.sh | 9 +++++++++
 2 files changed, 10 insertions(+)


base-commit: ad05a3d8e5a6a06443836b5e40434262d992889a
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-495%2FHebaWaly%2Fhints-for-unsuccessful-commit-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-495/HebaWaly/hints-for-unsuccessful-commit-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/495
-- 
gitgitgadget

             reply	other threads:[~2019-12-17  9:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17  9:17 Heba Waly via GitGitGadget [this message]
2019-12-17  9:17 ` [PATCH 1/1] commit: display advice hints when commit fails Heba Waly via GitGitGadget
2019-12-17 22:41   ` Junio C Hamano
2019-12-17 22:45   ` Emily Shaffer
2019-12-19  3:47     ` Heba Waly
2019-12-18  3:13   ` Jonathan Tan
2019-12-18 18:14     ` Junio C Hamano
2019-12-19  3:48     ` Heba Waly
2019-12-19  9:16 ` [PATCH v2 0/1] [Outreachy] " Heba Waly via GitGitGadget
2019-12-19  9:16   ` [PATCH v2 1/1] " Heba Waly via GitGitGadget
2019-12-19 19:14     ` Junio C Hamano
2019-12-19 19:22       ` Junio C Hamano
2019-12-19 19:47         ` Eric Sunshine
2019-12-19 19:57           ` Junio C Hamano
2019-12-20  2:31         ` Emily Shaffer
2019-12-20 18:34           ` Junio C Hamano
2019-12-20 21:39             ` Emily Shaffer
2019-12-31  0:04         ` Jonathan Tan
2019-12-31 19:06           ` Junio C Hamano
2020-01-02 19:56             ` Jonathan Tan
2019-12-19 18:26   ` [PATCH v2 0/1] [Outreachy] " Junio C Hamano
2019-12-19 18:54     ` Emily Shaffer
2019-12-19 19:23       ` Junio C Hamano
2019-12-19 19:45         ` Junio C Hamano
2019-12-21  4:37           ` Heba Waly
2019-12-21 23:54             ` Junio C Hamano
2019-12-21  5:02   ` Heba Waly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.495.git.1576574242.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=heba.waly@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).