git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Olaf Hering <olaf@aepfle.de>, Git List <git@vger.kernel.org>
Subject: Re: git fsck, badDate: invalid author/committer line - bad date
Date: Thu, 31 Oct 2019 13:12:10 -0400	[thread overview]
Message-ID: <CAPig+cTNq_gPxECZks7sNde4Q758Vixgpy9eL2B3xrKO-O+qNQ@mail.gmail.com> (raw)
In-Reply-To: <20191031165632.GA4348@szeder.dev>

On Thu, Oct 31, 2019 at 12:56 PM SZEDER Gábor <szeder.dev@gmail.com> wrote:
> All the usual warnings about rewriting already published history
> apply.  The hash of a couple of commits from 2009 might seem
> irrelevant now, a decade later, but after correcting those author and
> committer lines the hashes of all subsequent commits will inherently
> change as well.  This is, in general, upsetting for everyone who have
> cloned the repo and built their own work on top.  Furthermore, some
> commit messages refer to older commits by their hash (e.g. in
> 431dbd98ba: "Simplifies and updates commit
> dbef8dd3bf00417e75a12c851b053e49c9e1a79e"); those references will go
> stale after rewriting history, unless you put in extra work to update
> them.

For completeness for future readers of this thread who have cases when
rewriting history is a valid option, a tool such as Elijah's
git-filter-repo[1] can not only fix the "broken" email addresses, but
also can adjust hash references in commit messages so they don't go
stale.

[1]: https://github.com/newren/git-filter-repo

  reply	other threads:[~2019-10-31 17:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31  8:27 Olaf Hering
2019-10-31 10:15 ` SZEDER Gábor
2019-10-31 13:21   ` Olaf Hering
2019-10-31 16:56     ` SZEDER Gábor
2019-10-31 17:12       ` Eric Sunshine [this message]
2019-10-31 19:30   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cTNq_gPxECZks7sNde4Q758Vixgpy9eL2B3xrKO-O+qNQ@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=szeder.dev@gmail.com \
    --subject='Re: git fsck, badDate: invalid author/committer line - bad date' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).