From: Eric Sunshine <sunshine@sunshineco.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: Git List <git@vger.kernel.org>, Thomas Rast <tr@thomasrast.ch>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC PATCH] line-log: clarify [a,b) notation for ranges
Date: Tue, 7 Aug 2018 17:47:02 -0400 [thread overview]
Message-ID: <CAPig+cTVEq1AGvtxxonbU4PgqeG0fOy9CSDO7ThjVpfGoJaAJA@mail.gmail.com> (raw)
In-Reply-To: <be1dd423-f9de-a436-6127-02cce4ab1977@gmail.com>
On Tue, Aug 7, 2018 at 9:54 AM Andrei Rybak <rybak.a.v@gmail.com> wrote:
> line-log.[ch] use left-closed, right-open interval logic. Change comment
> and debug output to square brackets+parentheses notation to help
> developers avoid off-by-one errors.
> ---
This seems sensible. There might be some reviewers who suggest
different notation since "[...)" is not universal (see [1]), but I
think this is fine.
You'll want to add your sign-off, of course, when taking this out of RFC.
[1]: https://en.wikipedia.org/wiki/Interval_(mathematics)#Notations_for_intervals
> line-log.c also uses ASCII graphics |---| in some comments, like:
>
> /*
> * a: |-------
> * b: ------|
> */
>
> But I'm not sure if replacing them with
>
> /*
> * a: [-------
> * b: ------)
> */
>
> will be helpful.
Those comments seem to use horizontal ruling to make it clear where
one range ends and another begins, so they already do a good job
conveying what they represent. Changing them to use "["" and ")" might
make them less clear.
> Another possibility is to update comment for
> range_set_append_unsafe to read
>
> /* tack on a _new_ range [a,b) _at the end_ */
> void range_set_append_unsafe(struct range_set *rs, long a, long b)
It shouldn't hurt (though the existing "_at the end_" is rather
superfluous since "append" in the name says the that already).
next prev parent reply other threads:[~2018-08-07 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 13:54 [RFC PATCH] line-log: clarify [a,b) notation for ranges Andrei Rybak
2018-08-07 21:47 ` Eric Sunshine [this message]
2018-08-09 12:50 ` Johannes Schindelin
2018-08-08 16:26 ` [PATCH v2] " Andrei Rybak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTVEq1AGvtxxonbU4PgqeG0fOy9CSDO7ThjVpfGoJaAJA@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rybak.a.v@gmail.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).