From: Andrei Rybak <rybak.a.v@gmail.com>
To: git@vger.kernel.org
Cc: Thomas Rast <tr@thomasrast.ch>,
Eric Sunshine <sunshine@sunshineco.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: [RFC PATCH] line-log: clarify [a,b) notation for ranges
Date: Tue, 7 Aug 2018 15:54:30 +0200 [thread overview]
Message-ID: <be1dd423-f9de-a436-6127-02cce4ab1977@gmail.com> (raw)
line-log.[ch] use left-closed, right-open interval logic. Change comment
and debug output to square brackets+parentheses notation to help
developers avoid off-by-one errors.
---
Original idea for this change in recent thread about line-log changes:
https://public-inbox.org/git/9776862d-18b2-43ec-cfeb-829418d4d967@gmail.com/
line-log.c also uses ASCII graphics |---| in some comments, like:
/*
* a: |-------
* b: ------|
*/
But I'm not sure if replacing them with
/*
* a: [-------
* b: ------)
*/
will be helpful. Another possibility is to update comment for
range_set_append_unsafe to read
/* tack on a _new_ range [a,b) _at the end_ */
void range_set_append_unsafe(struct range_set *rs, long a, long b)
line-log.c | 4 ++--
line-log.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/line-log.c b/line-log.c
index fa9cfd5bd..60f3174ac 100644
--- a/line-log.c
+++ b/line-log.c
@@ -353,7 +353,7 @@ static void dump_range_set(struct range_set *rs, const char *desc)
int i;
printf("range set %s (%d items):\n", desc, rs->nr);
for (i = 0; i < rs->nr; i++)
- printf("\t[%ld,%ld]\n", rs->ranges[i].start, rs->ranges[i].end);
+ printf("\t[%ld,%ld)\n", rs->ranges[i].start, rs->ranges[i].end);
}
static void dump_line_log_data(struct line_log_data *r)
@@ -373,7 +373,7 @@ static void dump_diff_ranges(struct diff_ranges *diff, const char *desc)
printf("diff ranges %s (%d items):\n", desc, diff->parent.nr);
printf("\tparent\ttarget\n");
for (i = 0; i < diff->parent.nr; i++) {
- printf("\t[%ld,%ld]\t[%ld,%ld]\n",
+ printf("\t[%ld,%ld)\t[%ld,%ld)\n",
diff->parent.ranges[i].start,
diff->parent.ranges[i].end,
diff->target.ranges[i].start,
diff --git a/line-log.h b/line-log.h
index e2a5ee7c6..488c86409 100644
--- a/line-log.h
+++ b/line-log.h
@@ -6,7 +6,7 @@
struct rev_info;
struct commit;
-/* A range [start,end]. Lines are numbered starting at 0, and the
+/* A range [start,end). Lines are numbered starting at 0, and the
* ranges include start but exclude end. */
struct range {
long start, end;
--
2.18.0
next reply other threads:[~2018-08-07 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 13:54 Andrei Rybak [this message]
2018-08-07 21:47 ` [RFC PATCH] line-log: clarify [a,b) notation for ranges Eric Sunshine
2018-08-09 12:50 ` Johannes Schindelin
2018-08-08 16:26 ` [PATCH v2] " Andrei Rybak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be1dd423-f9de-a436-6127-02cce4ab1977@gmail.com \
--to=rybak.a.v@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).