From: "Matthias Aßhauer" <mha1993@live.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Matthias Aßhauer via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org,
"Louis Strous" <Louis.Strous@intellimagic.com>,
"Pranit Bauva" <pranit.bauva@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Denton Liu" <liu.denton@gmail.com>,
"Tanushree Tumane" <tanushreetumane@gmail.com>,
"Jeff Hostetler" <jeffhost@microsoft.com>,
"Miriam Rubio" <mirucam@gmail.com>,
"Matthias Aßhauer" <mha1993@live.de>
Subject: Re: [PATCH 0/3] git bisect visualize: find gitk on Windows again
Date: Thu, 3 Aug 2023 21:03:36 +0200 (CEST) [thread overview]
Message-ID: <DB9P250MB0692B33DE1EBFC26865D78C9A508A@DB9P250MB0692.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <xmqqy1is3qqn.fsf@gitster.g>
On Thu, 3 Aug 2023, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> "Matthias Aßhauer via GitGitGadget" <gitgitgadget@gmail.com>
>> writes:
>>
>>> Louis Strous reported a regression in git bisect visualize on Windows[1]
>>> that caused git bisect visualize to use git log instead of gitk unless
>>> explicitly called as git bisect visualize gitk.
>>>
>>> This patch series fixes that regression.
>>
>> Wonderful. It would be nice to describe where in the release
>> sequence the "regression" happened, if we know it. Perhaps you've
>> written about it in one of the patches? We'll find out.
>>
>> Thanks again.
>
> And the answer was in [2/3], if I am reading the proposed log
> messages correctly. When the "bisect visualize" was ported to C, we
> broke it.
Yes, that's correct.
>
> Thanks. Will try to queue based on 'maint'.
>
Please wait a moment, I'm currently preparing a V2 based on your feedback.
next prev parent reply other threads:[~2023-08-03 19:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 10:28 [PATCH 0/3] git bisect visualize: find gitk on Windows again Matthias Aßhauer via GitGitGadget
2023-08-03 10:28 ` [PATCH 1/3] compat: make path_lookup() available outside mingw.c Matthias Aßhauer via GitGitGadget
2023-08-03 10:28 ` [PATCH 2/3] run-command: teach locate_in_PATH about Windows Matthias Aßhauer via GitGitGadget
2023-08-03 16:13 ` Junio C Hamano
2023-08-03 10:28 ` [PATCH 3/3] docs: update when `git bisect visualize` uses `gitk` Matthias Aßhauer via GitGitGadget
2023-08-03 16:21 ` Junio C Hamano
2023-08-03 16:00 ` [PATCH 0/3] git bisect visualize: find gitk on Windows again Junio C Hamano
2023-08-03 18:50 ` Junio C Hamano
2023-08-03 19:03 ` Matthias Aßhauer [this message]
2023-08-03 19:56 ` Junio C Hamano
2023-08-04 4:08 ` [PATCH v2 " Matthias Aßhauer via GitGitGadget
2023-08-04 4:08 ` [PATCH v2 1/3] run-command: conditionally define locate_in_PATH() Matthias Aßhauer via GitGitGadget
2023-08-04 4:23 ` Junio C Hamano
2023-08-04 5:27 ` Matthias Aßhauer
2023-08-04 16:44 ` Junio C Hamano
2023-08-04 4:08 ` [PATCH v2 2/3] compat/mingw: implement a native locate_in_PATH() Matthias Aßhauer via GitGitGadget
2023-08-04 4:23 ` Junio C Hamano
2023-08-04 4:08 ` [PATCH v2 3/3] docs: update when `git bisect visualize` uses `gitk` Matthias Aßhauer via GitGitGadget
2023-08-04 4:32 ` Junio C Hamano
2023-08-04 5:27 ` Eric Sunshine
2023-08-04 5:54 ` Matthias Aßhauer
2023-08-04 16:45 ` Junio C Hamano
2023-08-04 16:57 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9P250MB0692B33DE1EBFC26865D78C9A508A@DB9P250MB0692.EURP250.PROD.OUTLOOK.COM \
--to=mha1993@live.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=Louis.Strous@intellimagic.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=liu.denton@gmail.com \
--cc=mirucam@gmail.com \
--cc=pranit.bauva@gmail.com \
--cc=tanushreetumane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).