Re: [PATCH 0/3] git bisect visualize: find gitk on Windows again

From: Junio C Hamano <gitster@pobox.com>
To: "Matthias Aßhauer via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
	"Louis Strous" <Louis.Strous@intellimagic.com>,
	"Pranit Bauva" <pranit.bauva@gmail.com>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Denton Liu" <liu.denton@gmail.com>,
	"Tanushree Tumane" <tanushreetumane@gmail.com>,
	"Jeff Hostetler" <jeffhost@microsoft.com>,
	"Miriam Rubio" <mirucam@gmail.com>,
	"Matthias Aßhauer" <mha1993@live.de>
Subject: Re: [PATCH 0/3] git bisect visualize: find gitk on Windows again
Date: Thu, 03 Aug 2023 09:00:49 -0700	[thread overview]
Message-ID: <xmqqo7jo5d5a.fsf@gitster.g> (raw)
In-Reply-To: <pull.1560.git.1691058498.gitgitgadget@gmail.com> ("Matthias =?utf-8?Q?A=C3=9Fhauer?= via GitGitGadget"'s message of "Thu, 03 Aug 2023 10:28:15 +0000")

"Matthias Aßhauer via GitGitGadget"  <gitgitgadget@gmail.com>
writes:

> Louis Strous reported a regression in git bisect visualize on Windows[1]
> that caused git bisect visualize to use git log instead of gitk unless
> explicitly called as git bisect visualize gitk.
>
> This patch series fixes that regression.

Wonderful.  It would be nice to describe where in the release
sequence the "regression" happened, if we know it.  Perhaps you've
written about it in one of the patches?  We'll find out.

Thanks again.

> [1]
> https://lore.kernel.org/git/VI1PR10MB2462F7B52FF2E3F59AFE94A7F500A@VI1PR10MB2462.EURPRD10.PROD.OUTLOOK.COM/
>
> Matthias Aßhauer (3):
>   compat: make path_lookup() available outside mingw.c
>   run-command: teach locate_in_PATH about Windows
>   docs: update when `git bisect visualize` uses `gitk`
>
>  Documentation/git-bisect.txt |  6 +++---
>  compat/mingw.c               | 20 ++++++++------------
>  compat/mingw.h               |  6 ++++++
>  run-command.c                |  8 ++++----
>  4 files changed, 21 insertions(+), 19 deletions(-)
>
>
> base-commit: fb7d80edcae482f4fa5d4be0227dc3054734e5f3
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1560%2Frimrul%2Fwin-bisect-visualize-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1560/rimrul/win-bisect-visualize-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1560