git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: Git svn fetches entire trunk on tags (change from 1.6.5.2 to 1.7.0)
@ 2010-02-17 23:54 Robert Zeh
  2010-02-18  0:06 ` Eric Wong
  0 siblings, 1 reply; 5+ messages in thread
From: Robert Zeh @ 2010-02-17 23:54 UTC (permalink / raw)
  To: Eric Wong; +Cc: git

On Feb 17, 2010, at 5:23 PM, Eric Wong <normalperson@yhbt.net> wrote:
> There was a rather large amount of changes between 1.6.5.2 so some
> regressions could've slipped in.  A bisection would definitely help
> us track down the cause.

I will attempt a bisection Thursday.

>
> Does the repository you're using svn:mergeinfo use by any chance?

The repository does use mergeinfo, but    much later in the revision  
history then when the problem shows up.

Do you have any advice on how to write a test for this behaviour,  
since the problem is not apparent from looking at the repo?  I do not  
like the idea of a test looking at a log but that is all I can think  
of right now.

Robert

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Git svn fetches entire trunk on tags (change from 1.6.5.2 to 1.7.0)
  2010-02-17 23:54 Git svn fetches entire trunk on tags (change from 1.6.5.2 to 1.7.0) Robert Zeh
@ 2010-02-18  0:06 ` Eric Wong
  2010-02-19 12:14   ` Robert Zeh
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Wong @ 2010-02-18  0:06 UTC (permalink / raw)
  To: Robert Zeh; +Cc: git, Andrew Myrick, Sam Vilain

Robert Zeh <robert.allan.zeh@gmail.com> wrote:
> On Feb 17, 2010, at 5:23 PM, Eric Wong <normalperson@yhbt.net> wrote:
>> There was a rather large amount of changes between 1.6.5.2 so some
>> regressions could've slipped in.  A bisection would definitely help
>> us track down the cause.
>
> I will attempt a bisection Thursday.

Awesome, thanks.

>> Does the repository you're using svn:mergeinfo use by any chance?
>
> The repository does use mergeinfo, but    much later in the revision  
> history then when the problem shows up.
>
> Do you have any advice on how to write a test for this behaviour, since 
> the problem is not apparent from looking at the repo?  I do not like the 
> idea of a test looking at a log but that is all I can think of right now.

Andrew and Sam are the people to ask about mergeinfo, but I've found
reading logs valuable for tracking down many issues in the past.

I'm not 100% convinced mergeinfo itself is the problem (but it's the
code I'm least familiar with), and there were also some changes with
globbing (which I believe were harmless improvements).

-- 
Eric Wong

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Git svn fetches entire trunk on tags (change from 1.6.5.2 to 1.7.0)
  2010-02-18  0:06 ` Eric Wong
@ 2010-02-19 12:14   ` Robert Zeh
  0 siblings, 0 replies; 5+ messages in thread
From: Robert Zeh @ 2010-02-19 12:14 UTC (permalink / raw)
  To: Eric Wong; +Cc: git, Andrew Myrick, Sam Vilain


On Feb 17, 2010, at 6:06 PM, Eric Wong <normalperson@yhbt.net> wrote:

> Robert Zeh <robert.allan.zeh@gmail.com> wrote:
>> On Feb 17, 2010, at 5:23 PM, Eric Wong <normalperson@yhbt.net> wrote:
>>> There was a rather large amount of changes between 1.6.5.2 so some
>>> regressions could've slipped in.  A bisection would definitely help
>>> us track down the cause.
>>
>> I will attempt a bisection Thursday.
>
> Awesome, thanks.

I now believe the real problem is that I had an ignore-paths set in  
the repo that fetched the entire trunk on branch.  Is this expected?

Robert
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Git svn fetches entire trunk on tags (change from 1.6.5.2 to 1.7.0)
  2010-02-17  1:17 Robert Zeh
@ 2010-02-17 23:23 ` Eric Wong
  0 siblings, 0 replies; 5+ messages in thread
From: Eric Wong @ 2010-02-17 23:23 UTC (permalink / raw)
  To: Robert Zeh; +Cc: git

Robert Zeh <robert.allan.zeh@gmail.com> wrote:
> Since upgrading from 1.6.5.2 to 1.7.0 I've noticed a change in how
> git svn fetches from the Subversion repository on tags.  Of course,
> for the repo I'm working with there are many more tags then branches.
> 1.6.5.2 gives me the following on a tag:
> 
> 
> r333 = b15f3f20710a1e282fb6ff62c13fad64376ad2b4 (refs/remotes/trunk)
> Found possible branch point:http://bt011us013s/prod_repos/trunk
> =>http://bt011us013s/prod_repos/tags/3.09.1255, 333
> Found branch parent: (refs/remotes/tags/3.09.1255)
> b15f3f20710a1e282fb6ff62c13fad64376ad2b4
> Following parent with do_switch
> Successfully followed parent
> 
> r334 = 77d132d69bc333e7c988a4f3af9d48a98dadf0d4 (refs/remotes/tags/3.09.1255)
> 
> With 1.7.0:
> r333 = b15f3f20710a1e282fb6ff62c13fad64376ad2b4 (refs/remotes/trunk)
> 
>         A       Enterprise/Header.txt
>         ....
> 
> r334 = 2c0e6dd89e81e7d18288e135f40f193b2ff22018 (refs/remotes/tags/3.09.1255)
> 
> The SHA1s are also different.
> 
> It would be nice if the entire branch wasn't fetched.

Hi Robert,

There was a rather large amount of changes between 1.6.5.2 so some
regressions could've slipped in.  A bisection would definitely help
us track down the cause.

Does the repository you're using svn:mergeinfo use by any chance?

-- 
Eric Wong

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Git svn fetches entire trunk on tags (change from 1.6.5.2 to 1.7.0)
@ 2010-02-17  1:17 Robert Zeh
  2010-02-17 23:23 ` Eric Wong
  0 siblings, 1 reply; 5+ messages in thread
From: Robert Zeh @ 2010-02-17  1:17 UTC (permalink / raw)
  To: git

Since upgrading from 1.6.5.2 to 1.7.0 I've noticed a change in how
git svn fetches from the Subversion repository on tags.  Of course,
for the repo I'm working with there are many more tags then branches.
1.6.5.2 gives me the following on a tag:


r333 = b15f3f20710a1e282fb6ff62c13fad64376ad2b4 (refs/remotes/trunk)
Found possible branch point:http://bt011us013s/prod_repos/trunk
=>http://bt011us013s/prod_repos/tags/3.09.1255, 333
Found branch parent: (refs/remotes/tags/3.09.1255)
b15f3f20710a1e282fb6ff62c13fad64376ad2b4
Following parent with do_switch
Successfully followed parent

r334 = 77d132d69bc333e7c988a4f3af9d48a98dadf0d4 (refs/remotes/tags/3.09.1255)

With 1.7.0:
r333 = b15f3f20710a1e282fb6ff62c13fad64376ad2b4 (refs/remotes/trunk)

        A       Enterprise/Header.txt
        ....

r334 = 2c0e6dd89e81e7d18288e135f40f193b2ff22018 (refs/remotes/tags/3.09.1255)

The SHA1s are also different.

It would be nice if the entire branch wasn't fetched.

Robert

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-02-19 12:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-17 23:54 Git svn fetches entire trunk on tags (change from 1.6.5.2 to 1.7.0) Robert Zeh
2010-02-18  0:06 ` Eric Wong
2010-02-19 12:14   ` Robert Zeh
  -- strict thread matches above, loose matches on Subject: below --
2010-02-17  1:17 Robert Zeh
2010-02-17 23:23 ` Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).