From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Arnout Engelen <arnout@bzzt.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] doc: make HTML manual reproducible
Date: Wed, 2 Dec 2020 00:41:23 +0000 [thread overview]
Message-ID: <X8bis7ZnU8FViHjk@camp.crustytoothpaste.net> (raw)
In-Reply-To: <20201201095037.20715-1-arnout@bzzt.net>
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
On 2020-12-01 at 09:50:37, Arnout Engelen wrote:
> This makes sure the generated id's inside the html version of the
> documentation use the same id's when the same version of the
> manual is generated twice.
>
> Signed-off-by: Arnout Engelen <arnout@bzzt.net>
> ---
> Documentation/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 80d1908a44..4d1fd5e31f 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -380,7 +380,7 @@ SubmittingPatches.txt: SubmittingPatches
> $(QUIET_GEN) cp $< $@
>
> XSLT = docbook.xsl
> -XSLTOPTS = --xinclude --stringparam html.stylesheet docbook-xsl.css
> +XSLTOPTS = --xinclude --stringparam html.stylesheet docbook-xsl.css --stringparam generate.consistent.ids 1
I think we'll want --param here, not --stringparam. This is documented
to be an integer, not a string. The difference is that --stringparam
sets the value to "1" (that is, a string with a single character)
instead of the integer 1.
We may also want to wrap this to the next line like so:
XSLTOPTS = --xinclude --stringparam html.stylesheet docbook-xsl.css
XSLTOPTS += --param generate.consistent.ids 1
Otherwise, I think this is a valuable change, as I've mentioned
downthread. I already use this option on my own projects for the same
reason.
--
brian m. carlson (he/him or they/them)
Houston, Texas, US
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2020-12-02 0:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 9:50 [PATCH] doc: make HTML manual reproducible Arnout Engelen
2020-12-01 15:41 ` Todd Zullinger
2020-12-01 19:18 ` Martin Ågren
2020-12-02 1:54 ` Jeff King
2020-12-01 19:27 ` Junio C Hamano
2020-12-01 19:57 ` Martin Ågren
2020-12-02 0:36 ` brian m. carlson
2020-12-02 16:07 ` Todd Zullinger
2020-12-02 22:35 ` Junio C Hamano
2020-12-02 23:45 ` brian m. carlson
2020-12-03 1:33 ` Junio C Hamano
2020-12-03 2:00 ` Todd Zullinger
2020-12-03 2:31 ` Re* " Junio C Hamano
2020-12-03 8:07 ` Arnout Engelen
2020-12-02 0:41 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8bis7ZnU8FViHjk@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=arnout@bzzt.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).