git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Phillip Wood <phillip.wood123@gmail.com>,
	Calvin Wan <calvinwan@google.com>
Subject: Re: [PATCH 3/3] run-command tests: test stdout of run_command_parallel()
Date: Sat, 29 Oct 2022 16:15:04 -0400	[thread overview]
Message-ID: <Y12JyOQZT8xKHC7k@nand.local> (raw)
In-Reply-To: <patch-3.3-6d6c2241bf2-20221029T025520Z-avarab@gmail.com>

On Sat, Oct 29, 2022 at 04:59:47AM +0200, Ævar Arnfjörð Bjarmason wrote:
> Extend the tests added in c553c72eed6 (run-command: add an
> asynchronous parallel child processor, 2015-12-15) to test stdout in
> addition to stderr.
>
> When the "ungroup" feature was added in fd3aaf53f71 (run-command: add
> an "ungroup" option to run_process_parallel(), 2022-06-07) its tests
> were made to test both the stdout and stderr, but these existing tests
> were left alone. Let's also exhaustively test our expected output
> here.

Makes sense, this patch looks good. Thanks.

Thanks,
Taylor

      reply	other threads:[~2022-10-29 20:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-29  2:59 [PATCH 0/3] tests: improve misc run-command, hook, submodule tests Ævar Arnfjörð Bjarmason
2022-10-29  2:59 ` [PATCH 1/3] hook tests: fix redirection logic error in 96e7225b310 Ævar Arnfjörð Bjarmason
2022-10-29 20:11   ` Taylor Blau
2022-10-31 12:44     ` Ævar Arnfjörð Bjarmason
2022-10-31 23:56       ` Taylor Blau
2022-10-29  2:59 ` [PATCH 2/3] submodule tests: reset "trace.out" between "grep" invocations Ævar Arnfjörð Bjarmason
2022-10-29 20:13   ` Taylor Blau
2022-10-31 12:50     ` Ævar Arnfjörð Bjarmason
2022-10-31 23:58       ` Taylor Blau
2022-10-29  2:59 ` [PATCH 3/3] run-command tests: test stdout of run_command_parallel() Ævar Arnfjörð Bjarmason
2022-10-29 20:15   ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y12JyOQZT8xKHC7k@nand.local \
    --to=me@ttaylorr.com \
    --cc=avarab@gmail.com \
    --cc=calvinwan@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).