From: Jeff King <firstname.lastname@example.org> To: "Ævar Arnfjörð Bjarmason" <email@example.com> Cc: Junio C Hamano <firstname.lastname@example.org>, email@example.com, Johannes Schindelin <Johannes.Schindelin@gmx.de> Subject: Re: [PATCH] Makefile: generate 'git' as 'cc [...] -o git+ && mv git+ git' Date: Mon, 8 Mar 2021 13:26:00 -0500 [thread overview] Message-ID: <YEZsON5OxUiDkqPG@coredump.intra.peff.net> (raw) In-Reply-To: <firstname.lastname@example.org> On Mon, Mar 08, 2021 at 01:38:32PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> Change the compilation of the main 'git' binary to not have the CC > >> clobber 'git' in-place. This means that e.g. running the test suite > >> in-place and recompiling won't fail whatever tests happen to be > >> running for the duration of the binary being regenerated. > > > > I am not sure why I would want to support the workflow this is > > trying to help. > > Because it also allows me and others to do more testing on patches to > git.git. > > If I'm working on a patch to e.g. git-fsck I might be doing > edit->save->some-tests, where "some-tests" are a subset of the test > suite I think is relevant to fsck. > > But after doing N commits with passing tests I might notice that some > other part of the test suite I didn't expect to have anything to do with > fsck broke because I wasn't running that test. > > I wasn't running that test because I'm not going to wait 10-15 minutes > for it to run while actively editing, but will wait 30s-1m for 10-50 > test files to run. > > So I can also have the full test suite running in a loop in some side > window that'll give me a headsup if the "while do-full-tests; [...]" > loop breaks, at which point I'm likely to investigate it sooner than > otherwise, and not waste time going down the wrong path. > > You can of course do that now, but it requires having a worktree on the > side or whatever, which isn't always ideal (sometimes I'd like to have > these tests on uncommitted changes). I don't always use it, but I have a "ci" script that just runs the test on each individual commit in a loop. The interesting things about it (beyond a simple loop) are: - it operates in a worktree (that copies the config.mak from the main worktree if necessary). - it uses Michael Haggerty's git-test to memoize results for a given tree. That makes it reasonable to leave running in the background, where it will only use CPU when there's something useful to do. I also use git-test for "git rebase -x", so a final "is each commit OK" check usually runs instantly, because the results are cached. - it uses inotifywait to decide when HEAD has been updated. This is mostly a fun hack. It could also just poll every 10 seconds or whatever. - it triggers a custom command when the tests fail. I can share my sad-trombone.wav with you if you need. ;) Your mention of 10-15 minutes makes me wonder why your system is so slow, though. I generally run the whole suite (minus cvs/svn/p4 bits) in under a minute. I know it's _much_ slower on Windows, but I didn't think that was your platform. (In general, I'm mildly negative on your patch here. I have definitely run into this myself, but I think having the test suite loudly complain is a good way to remind you that you have not in fact run the whole suite on a given build).  https://github.com/peff/git/blob/meta/ci  https://github.com/mhagger/git-test -Peff
next prev parent reply other threads:[~2021-03-08 18:26 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-07 13:20 Ævar Arnfjörð Bjarmason 2021-03-07 20:41 ` Junio C Hamano 2021-03-08 12:38 ` Ævar Arnfjörð Bjarmason 2021-03-08 17:21 ` Junio C Hamano 2021-03-08 18:26 ` Jeff King [this message] 2021-03-29 16:20 ` [PATCH v2 0/5] Makefile: don't die on AIX with open ./git Ævar Arnfjörð Bjarmason 2021-03-29 16:20 ` [PATCH v2 1/5] Makefile: rename objects in-place, don't clobber Ævar Arnfjörð Bjarmason 2021-03-29 18:21 ` Junio C Hamano 2021-03-29 18:26 ` Junio C Hamano 2021-03-29 23:24 ` Ævar Arnfjörð Bjarmason 2021-03-30 0:21 ` Junio C Hamano 2021-03-31 14:17 ` Ævar Arnfjörð Bjarmason 2021-03-31 18:50 ` Junio C Hamano 2021-03-29 16:20 ` [PATCH v2 2/5] Makefile: rename scripts " Ævar Arnfjörð Bjarmason 2021-03-29 18:40 ` Junio C Hamano 2021-03-29 23:28 ` Ævar Arnfjörð Bjarmason 2021-03-29 16:20 ` [PATCH v2 3/5] Makefile: don't needlessly "rm $@ $@+" before "mv $@+ $@" Ævar Arnfjörð Bjarmason 2021-03-29 18:46 ` Junio C Hamano 2021-03-29 16:20 ` [PATCH v2 4/5] Makefile: add the ".DELETE_ON_ERROR" flag Ævar Arnfjörð Bjarmason 2021-03-29 18:51 ` Junio C Hamano 2021-03-29 23:31 ` Ævar Arnfjörð Bjarmason 2021-03-29 23:58 ` Junio C Hamano 2021-03-30 15:11 ` Jeff King 2021-03-30 18:36 ` Junio C Hamano 2021-03-31 6:58 ` Jeff King 2021-03-31 18:36 ` Junio C Hamano 2021-03-31 22:29 ` Johannes Schindelin 2021-03-29 16:20 ` [PATCH v2 5/5] Makefile: don't "rm configure" before generating it Ævar Arnfjörð Bjarmason 2021-03-29 16:31 ` [PATCH 0/6] Makefile: make non-symlink & non-hardlink install sane Ævar Arnfjörð Bjarmason 2021-03-29 16:31 ` [PATCH 1/6] Makefile: symlink the same way under "symlinks" and "no hardlinks" Ævar Arnfjörð Bjarmason 2021-03-29 22:17 ` Junio C Hamano 2021-03-29 16:31 ` [PATCH 2/6] Makefile: begin refactoring out "ln || ln -s || cp" pattern Ævar Arnfjörð Bjarmason 2021-03-29 22:20 ` Junio C Hamano 2021-03-29 16:31 ` [PATCH 3/6] Makefile: refactor " Ævar Arnfjörð Bjarmason 2021-03-29 22:24 ` Junio C Hamano 2021-03-30 15:20 ` Jeff King 2021-03-30 18:36 ` Junio C Hamano 2021-03-29 16:31 ` [PATCH 4/6] Makefile: make INSTALL_SYMLINKS affect the build directory Ævar Arnfjörð Bjarmason 2021-03-29 22:31 ` Junio C Hamano 2021-03-31 14:04 ` Ævar Arnfjörð Bjarmason 2021-03-29 16:31 ` [PATCH 5/6] Makefile: use "ln -f" instead of "rm && ln" Ævar Arnfjörð Bjarmason 2021-03-29 22:46 ` Junio C Hamano 2021-03-29 16:31 ` [PATCH 6/6] Makefile: add a INSTALL_FALLBACK_LN_CP mode Ævar Arnfjörð Bjarmason 2021-03-29 22:53 ` Junio C Hamano 2021-03-31 14:03 ` Ævar Arnfjörð Bjarmason 2021-03-31 18:45 ` Junio C Hamano 2021-03-31 19:01 ` Ævar Arnfjörð Bjarmason 2021-03-29 23:08 ` [PATCH 0/6] Makefile: make non-symlink & non-hardlink install sane Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YEZsON5OxUiDkqPG@coredump.intra.peff.net \ --email@example.com \ --cc=Johannes.Schindelin@gmx.de \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] Makefile: generate '\''git'\'' as '\''cc [...] -o git+ && mv git+ git'\''' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).