From: Jeff King <firstname.lastname@example.org>
To: Will Chandler <email@example.com>
Cc: Junio C Hamano <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org
Subject: Re: [PATCH] refs: cleanup directories when deleting packed ref
Date: Mon, 10 May 2021 21:35:19 -0400 [thread overview]
Message-ID: <YJnfV7op4yhyLqdg@coredump.intra.peff.net> (raw)
On Sat, May 08, 2021 at 01:00:43AM -0400, Will Chandler wrote:
> Subject: [PATCH v2] refs: cleanup directories when deleting packed ref
> When deleting a packed ref via 'update-ref -d', a lockfile is made in
> the directory that would contain the loose copy of that ref, creating
> any directories in the ref's path that do not exist. When the
> transaction completes, the lockfile is deleted, but any empty parent
> directories made when creating the lockfile are left in place. These
> empty directories are not removed by 'pack-refs' or other housekeeping
> tasks and will accumulate over time.
> When deleting a loose ref, we remove all empty parent directories at the
> end of the transaction.
> This commit applies the parent directory cleanup logic used when
> deleting loose refs to packed refs as well.
This thread got off on a tangent about threads, but to get back to the
main idea: this v2 patch looks good to me. Thank you very much for
finding and fixing it.
Regarding threads, I agree with everything Junio already said. My only
suggestion would be to make sure the "Subject" above becomes the actual
email subject, rather than an in-body header (that may be what confused
the b4 tool, but more importantly, threaded readers like mutt will show
the changed subject in the thread index, making it very clear at a
glance that there is a v2 and not just more discussion).
next prev parent reply other threads:[~2021-05-11 1:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 14:37 [PATCH] refs: cleanup directories when deleting packed ref Will Chandler
2021-05-07 21:56 ` Jeff King
2021-05-07 22:02 ` Jeff King
2021-05-07 22:57 ` Jeff King
2021-05-08 4:27 ` Will Chandler
2021-05-08 5:00 ` Will Chandler
2021-05-08 5:21 ` Bagas Sanjaya
2021-05-08 6:24 ` Junio C Hamano
2021-05-09 18:45 ` Will Chandler
2021-05-10 1:15 ` Junio C Hamano
2021-05-11 1:35 ` Jeff King [this message]
2021-05-11 4:58 ` Junio C Hamano
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).