From: Jeff King <firstname.lastname@example.org> To: Ben Humphreys <email@example.com> Cc: Junio C Hamano <firstname.lastname@example.org>, Christopher Schenk <email@example.com>, firstname.lastname@example.org Subject: [PATCH 0/2] fix v2.32.0-rc0 bug with Negotiate / HTTP_NOAUTH Date: Tue, 18 May 2021 02:26:47 -0400 [thread overview] Message-ID: <YKNeJ+NKUbD5ixA9@coredump.intra.peff.net> (raw) In-Reply-To: <YKNVop80H8xSTCjz@coredump.intra.peff.net> On Tue, May 18, 2021 at 01:50:27AM -0400, Jeff King wrote: > So perhaps somebody can come up with something clever, but I suspect we > may need to just revert this for the v2.32 release, and re-break the > case that 1b0d9545bb8 was trying to solve. > > We probably should beef up the tests around http's credential-rejection, > too, to catch this regression. Here are some patches. The first one adds the tests, and I think is an obvious improvement. The second one does the revert. I'd be quite happy if somebody wants to figure out how to fix it in a way that addresses the original problem, and then we can replace that. But in the meantime, I think it makes sense to prepare the revert, as we wouldn't want to release v2.32.0 with the bug. [1/2]: t5551: test http interaction with credential helpers [2/2]: Revert "remote-curl: fall back to basic auth if Negotiate fails" http.c | 15 +++++++------- t/t5551-http-fetch-smart.sh | 41 +++++++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+), 8 deletions(-) -Peff
next prev parent reply other threads:[~2021-05-18 6:26 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-18 3:07 Git 2.23.0-rc0 HTTP authentication failure - error message change Ben Humphreys 2021-05-18 5:50 ` Jeff King 2021-05-18 6:26 ` Jeff King [this message] 2021-05-18 6:27 ` [PATCH 1/2] t5551: test http interaction with credential helpers Jeff King 2021-05-18 6:27 ` [PATCH 2/2] Revert "remote-curl: fall back to basic auth if Negotiate fails" Jeff King 2021-05-19 13:58 ` Derrick Stolee 2021-05-19 14:14 ` Jeff King 2021-05-19 14:53 ` Derrick Stolee 2021-05-19 1:12 ` [PATCH 0/2] fix v2.32.0-rc0 bug with Negotiate / HTTP_NOAUTH Junio C Hamano 2021-05-19 0:12 ` Git 2.23.0-rc0 HTTP authentication failure - error message change brian m. carlson 2021-05-19 11:49 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YKNeJ+NKUbD5ixA9@coredump.intra.peff.net \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/2] fix v2.32.0-rc0 bug with Negotiate / HTTP_NOAUTH' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).