From: Junio C Hamano <email@example.com> To: Jeff King <firstname.lastname@example.org> Cc: Ben Humphreys <email@example.com>, Christopher Schenk <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH 0/2] fix v2.32.0-rc0 bug with Negotiate / HTTP_NOAUTH Date: Wed, 19 May 2021 10:12:15 +0900 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <YKNeJ+NKUbD5ixA9@coredump.intra.peff.net> (Jeff King's message of "Tue, 18 May 2021 02:26:47 -0400") Jeff King <email@example.com> writes: > Here are some patches. The first one adds the tests, and I think is an > obvious improvement. > > The second one does the revert. I'd be quite happy if somebody wants to > figure out how to fix it in a way that addresses the original problem, > and then we can replace that. But in the meantime, I think it makes > sense to prepare the revert, as we wouldn't want to release v2.32.0 with > the bug. I'll queue these directly on top of the original topic, so that even a merge of the branch by mistake down to maint won't break. I saw brian has already floated an idea to solve the original issue, and I'd encourage people to help finding a proper solution, but let's leave the actual application of such a change for the next cycle. Thanks.
next prev parent reply other threads:[~2021-05-19 1:12 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-18 3:07 Git 2.23.0-rc0 HTTP authentication failure - error message change Ben Humphreys 2021-05-18 5:50 ` Jeff King 2021-05-18 6:26 ` [PATCH 0/2] fix v2.32.0-rc0 bug with Negotiate / HTTP_NOAUTH Jeff King 2021-05-18 6:27 ` [PATCH 1/2] t5551: test http interaction with credential helpers Jeff King 2021-05-18 6:27 ` [PATCH 2/2] Revert "remote-curl: fall back to basic auth if Negotiate fails" Jeff King 2021-05-19 13:58 ` Derrick Stolee 2021-05-19 14:14 ` Jeff King 2021-05-19 14:53 ` Derrick Stolee 2021-05-19 1:12 ` Junio C Hamano [this message] 2021-05-19 0:12 ` Git 2.23.0-rc0 HTTP authentication failure - error message change brian m. carlson 2021-05-19 11:49 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/2] fix v2.32.0-rc0 bug with Negotiate / HTTP_NOAUTH' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).