From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, jonathantanmy@google.com
Subject: Re: [PATCH] pack-bitmap: clarify comment in filter_bitmap_exclude_type()
Date: Tue, 20 Jul 2021 17:02:24 -0400 [thread overview]
Message-ID: <YPc54AdUqD6T31ad@coredump.intra.peff.net> (raw)
In-Reply-To: <0d52628985bf4f499e0d5622ea40cdf499e73ebe.1626812121.git.me@ttaylorr.com>
On Tue, Jul 20, 2021 at 04:16:22PM -0400, Taylor Blau wrote:
> The code that eventually became filter_bitmap_exclude_type() was
> originally introduced in 4f3bd5606a (pack-bitmap: implement BLOB_NONE
> filtering, 2020-02-14) to accelerate BLOB_NONE filters with bitmaps.
>
> In 856e12c18a (pack-bitmap.c: make object filtering functions generic,
> 2020-05-04), it became filter_bitmap_exclude_type(). But not all of the
> comments were updated to be agnostic to the provided type.
>
> Remove the remaining comments which should have been updated in
> 856e12c18a to reflect the type-agnostic nature of the function.
>
> Signed-off-by: Taylor Blau <me@ttaylorr.com>
> ---
> Noticed while I was reading some code in this area to see if we had
> accelerated the relatively new type filters. This trivial fix hopefully
> shouldn't produce conflicts with other in-flight bitmap series.
Yep, this looks good. I wrote a near-identical patch while working on
[1], but that topic got stalled on "how is this part of partial clones
even supposed to work?". But there's no reason not to make this trivial
fix in isolation.
-Peff
next prev parent reply other threads:[~2021-07-20 21:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 20:16 [PATCH] pack-bitmap: clarify comment in filter_bitmap_exclude_type() Taylor Blau
2021-07-20 21:02 ` Jeff King [this message]
2021-07-20 21:05 ` Taylor Blau
2021-07-20 21:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPc54AdUqD6T31ad@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).