From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Johannes Sixt" <j6t@kdbg.org>,
"Phillip Wood" <phillip.wood123@gmail.com>,
"Luc Van Oostenryck" <luc.vanoostenryck@gmail.com>
Subject: Re: [PATCH v2 2/5] *.[ch] *_INIT macros: use { 0 } for a "zero out" idiom
Date: Mon, 27 Sep 2021 20:46:16 -0400 [thread overview]
Message-ID: <YVJl2OPT9RRVEpQa@coredump.intra.peff.net> (raw)
In-Reply-To: <87h7e5zgjw.fsf@evledraar.gmail.com>
On Tue, Sep 28, 2021 at 02:25:16AM +0200, Ævar Arnfjörð Bjarmason wrote:
> It seems like we should just revert 1c96642326, looking at the history
> of sparse.git there's:
>
> - 537e3e2d (univ-init: conditionally accept { 0 } without warnings, 2020-05-18)
>
> Followed by git.git's 1c96642326 a few days later, but then in sparse.git:
>
> - 41f651b4 (univ-init: set default to -Wno-universal-initializer, 2020-05-29)
>
> I.e. a few days after the workaround in git.git the upstream repo
> changed the default. The 537e3e2d isn't in any release of sparse that
> 41f651b4 isn't in, they both first appeared in v0.6.2.
>
> So us having -Wno-universal-initializer only seems useful if you're
> using some old commit in sparse.git.
>
> Having written the above I found
> https://lore.kernel.org/git/20200530162432.a7fitzjc53hsn2ej@ltop.local/;
> i.e. sparse's maintainer pretty much saying the same thing.
Yeah, that seems reasonable. If somebody has an old version of sparse
they'll presumably see actual "don't use 0 to initialize a pointer"
warnings, as opposed to "hey, I don't understand -Wno-universal-initializer".
But either way, they should upgrade.
-Peff
next prev parent reply other threads:[~2021-09-28 0:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 0:39 [PATCH 0/5] Designated initializer cleanup & conversion Ævar Arnfjörð Bjarmason
2021-09-27 0:39 ` [PATCH 1/5] submodule-config.h: remove unused SUBMODULE_INIT macro Ævar Arnfjörð Bjarmason
2021-09-27 0:39 ` [PATCH 2/5] *.[ch] *_INIT macros: use { 0 } for a "zero out" idiom Ævar Arnfjörð Bjarmason
2021-09-27 2:27 ` Eric Sunshine
2021-09-27 6:35 ` Johannes Sixt
2021-09-27 20:25 ` Junio C Hamano
2021-09-27 0:39 ` [PATCH 3/5] *.h _INIT macros: don't specify fields equal to 0 Ævar Arnfjörð Bjarmason
2021-09-27 0:39 ` [PATCH 4/5] *.h: move some *_INIT to designated initializers Ævar Arnfjörð Bjarmason
2021-09-27 0:39 ` [PATCH 5/5] cbtree.h: define cb_init() in terms of CBTREE_INIT Ævar Arnfjörð Bjarmason
2021-09-27 6:37 ` Johannes Sixt
2021-09-27 11:02 ` Ævar Arnfjörð Bjarmason
2021-09-27 23:54 ` Jeff King
2021-09-28 6:15 ` Johannes Sixt
2021-09-28 18:32 ` Junio C Hamano
2021-09-28 19:42 ` Ævar Arnfjörð Bjarmason
2021-09-28 20:50 ` Junio C Hamano
2021-09-27 9:13 ` Phillip Wood
2021-09-27 11:00 ` Ævar Arnfjörð Bjarmason
2021-09-30 10:01 ` Phillip Wood
2021-09-27 12:54 ` [PATCH v2 0/5] Designated initializer cleanup & conversion Ævar Arnfjörð Bjarmason
2021-09-27 12:54 ` [PATCH v2 1/5] submodule-config.h: remove unused SUBMODULE_INIT macro Ævar Arnfjörð Bjarmason
2021-09-27 23:34 ` Jeff King
2021-09-27 12:54 ` [PATCH v2 2/5] *.[ch] *_INIT macros: use { 0 } for a "zero out" idiom Ævar Arnfjörð Bjarmason
2021-09-27 23:24 ` Jeff King
2021-09-28 0:25 ` Ævar Arnfjörð Bjarmason
2021-09-28 0:46 ` Jeff King [this message]
2021-09-28 1:44 ` Ramsay Jones
2021-09-27 12:54 ` [PATCH v2 3/5] *.h _INIT macros: don't specify fields equal to 0 Ævar Arnfjörð Bjarmason
2021-09-27 21:54 ` Junio C Hamano
2021-09-27 12:54 ` [PATCH v2 4/5] *.h: move some *_INIT to designated initializers Ævar Arnfjörð Bjarmason
2021-09-27 23:57 ` Junio C Hamano
2021-09-27 12:54 ` [PATCH v2 5/5] cbtree.h: define cb_init() in terms of CBTREE_INIT Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVJl2OPT9RRVEpQa@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=martin.agren@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).