From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>,
Adam Dinwoodie <adam@dinwoodie.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: t0301-credential-cache test failure on cygwin
Date: Thu, 7 Jul 2022 14:29:16 -0400 [thread overview]
Message-ID: <Yscl/Jx4g74RwkCK@coredump.intra.peff.net> (raw)
In-Reply-To: <4529b11a-e514-6676-f427-ffaec484e8f1@ramsayjones.plus.com>
On Thu, Jul 07, 2022 at 04:17:08PM +0100, Ramsay Jones wrote:
> Also, I would like to understand why the code is written as it is
> currently. I'm sure there must be a good reason - I just don't know
> what it is! I suspect (ie I'm guessing), it has something to do with
> operating in a high contention context [TOCTOU on socket?] ... dunno. ;-)
By the way, I was slightly surprised you did not find the explanation in
the commit history. A blame[1] of credential-cache--daemon.c shows that
the comment was added by 7d5e9c9849 (credential-cache--daemon: clarify
"exit" action semantics, 2016-03-18) which mentions the race in the
tests. And then searching for that commit message in the list yields the
thread I linked earlier with more context[2].
I mention this not as a criticism, because your digging for backstory
was otherwise quite thorough. It's only _because_ it was so thorough
that I was surprised you didn't find that commit. ;) So I offer it only
as a suggestion for future digging.
-Peff
[1] Likewise this works:
git log --follow -S'important that we clean up' builtin/credential-cache--daemon.c
but the --follow is necessary because of the rename when it became a
builtin. It's cool that "blame" handles this seamlessly. :)
[2] Finding the original patch on the list is my go-to trick when a
commit message hasn't sufficiently explained things. I know Junio
was for a while (is still?) kept a git-notes mapping of commits to
emails. In practice, I usually just do a manual search for a few
unique-looking phrases from the commit message. That should be
pretty easy with lore these days, though I do it with a local
archive indexed by notmuch.
-Peff
next prev parent reply other threads:[~2022-07-07 18:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 1:50 t0301-credential-cache test failure on cygwin Ramsay Jones
2022-07-07 6:15 ` Junio C Hamano
2022-07-07 15:17 ` Ramsay Jones
2022-07-07 18:19 ` Jeff King
2022-07-07 18:29 ` Jeff King [this message]
2022-07-07 19:14 ` Ramsay Jones
2022-07-11 7:49 ` Adam Dinwoodie
2022-07-11 13:39 ` Adam Dinwoodie
2022-07-11 14:56 ` Ramsay Jones
2022-07-13 14:42 ` Adam Dinwoodie
2022-07-13 19:16 ` Jeff King
2022-07-13 20:35 ` Ramsay Jones
2022-07-07 18:12 ` Jeff King
2022-07-07 18:26 ` Junio C Hamano
2022-07-07 19:59 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yscl/Jx4g74RwkCK@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=adam@dinwoodie.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).