Re: t0301-credential-cache test failure on cygwin

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>,
	Adam Dinwoodie <adam@dinwoodie.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: t0301-credential-cache test failure on cygwin
Date: Thu, 7 Jul 2022 20:14:31 +0100	[thread overview]
Message-ID: <fa951e27-7b7b-848c-01c8-f706f97d87e7@ramsayjones.plus.com> (raw)
In-Reply-To: <Yscl/Jx4g74RwkCK@coredump.intra.peff.net>

On 07/07/2022 19:29, Jeff King wrote:
> On Thu, Jul 07, 2022 at 04:17:08PM +0100, Ramsay Jones wrote:
> 
>> Also, I would like to understand why the code is written as it is
>> currently. I'm sure there must be a good reason - I just don't know
>> what it is! I suspect (ie I'm guessing), it has something to do with
>> operating in a high contention context [TOCTOU on socket?] ... dunno. ;-)
> 
> By the way, I was slightly surprised you did not find the explanation in
> the commit history. A blame[1] of credential-cache--daemon.c shows that
> the comment was added by 7d5e9c9849 (credential-cache--daemon: clarify
> "exit" action semantics, 2016-03-18) which mentions the race in the
> tests. And then searching for that commit message in the list yields the
> thread I linked earlier with more context[2].

Heh, just 10min before I read your previous email (er, actually your
previous, previous email) I found commit 7d5e9c9849 (credential-cache--daemon:
clarify "exit" action semantics, 2016-03-18). I hadn't had time to dig
any further yet (as usual I'm trying to do 3 things at the same time).

What can I say? It was nearly 3am and I wanted to go bed. It took nearly
50min just to write the email. This was just a _quick_ look remember! ;-)

Sorry!

ATB,
Ramsay Jones