From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Wong <e@80x24.org>,
git@vger.kernel.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [PATCH 2/2] git-compat-util: use gettimeofday for current time
Date: Mon, 20 Mar 2023 16:35:09 -0400 [thread overview]
Message-ID: <ZBjDfT15489G1o3Q@nand.local> (raw)
In-Reply-To: <xmqqh6ufo01u.fsf@gitster.g>
On Mon, Mar 20, 2023 at 09:33:01AM -0700, Junio C Hamano wrote:
> Yeah, this is interesting.
Definitely so. You learn something new every day ;-).
> I however wonder if we should follow our usual pattern of implementing
> git_time() with the identical function signature as what we replace
> (i.e. system's time()), and #undef/#define the symbol we replace with
> git_time, though. Wouldn't it make [1/2] a lot smaller and
> future-proof?
Yeah, I agree here, too. It was my first thought when I started reading
Paul's patches here. I think that your approach is sound and I would be
happy to see you queue it.
Thanks,
Taylor
next prev parent reply other threads:[~2023-03-20 20:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 6:43 [PATCH 0/2] use gettimeofday for current time Paul Eggert
2023-03-19 6:43 ` [PATCH 1/2] git-compat-util: time_now " Paul Eggert
2023-03-19 6:43 ` [PATCH 2/2] git-compat-util: use gettimeofday " Paul Eggert
2023-03-19 19:34 ` Eric Wong
2023-03-20 16:33 ` Junio C Hamano
2023-03-20 17:01 ` Junio C Hamano
2023-03-20 19:00 ` Paul Eggert
2023-03-20 19:40 ` Junio C Hamano
2023-03-20 20:36 ` Taylor Blau
2023-03-20 20:35 ` Taylor Blau [this message]
2023-03-20 23:05 ` [PATCH v2] git-compat-util: use gettimeofday(2) for time(2) Junio C Hamano
2023-03-20 23:21 ` Paul Eggert
2023-03-21 16:20 ` Junio C Hamano
2023-03-21 17:44 ` Konstantin Khomoutov
2023-03-21 18:22 ` Junio C Hamano
2023-03-21 18:22 ` Jeff King
2023-03-21 19:06 ` Taylor Blau
2023-03-21 20:04 ` Junio C Hamano
2023-03-22 17:11 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBjDfT15489G1o3Q@nand.local \
--to=me@ttaylorr.com \
--cc=e@80x24.org \
--cc=eggert@cs.ucla.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).