git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Paul Eggert <eggert@cs.ucla.edu>,
	Eric Wong <e@80x24.org>
Subject: Re: [PATCH v2] git-compat-util: use gettimeofday(2) for time(2)
Date: Tue, 21 Mar 2023 15:06:40 -0400	[thread overview]
Message-ID: <ZBoAQFCWGhwIO963@nand.local> (raw)
In-Reply-To: <20230321182252.GJ3119834@coredump.intra.peff.net>

On Tue, Mar 21, 2023 at 02:22:52PM -0400, Jeff King wrote:
> The disadvantage is that it's longer to type, and that you have to
> declare a timeval in the caller. So maybe it's a dumb idea.

I don't think it's a dumb idea per-se, but I think that being able to
pass `time(NULL)` around without having to create a timeval and pass a
pointer to *it* before then giving that timeval to some other function
is a nice advantage.

So, yeah, we probably should just avoid calling time() altogether, but
in practice I like the solution of redefining time() to do the right
thing and implement it by calling gettimeofday().

...Which is a long way of saying that I agree with you that this
approach looks good, and that I'd like to avoid putting time() in the
list of banned functions.

Thanks,
Taylor

  reply	other threads:[~2023-03-21 19:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-19  6:43 [PATCH 0/2] use gettimeofday for current time Paul Eggert
2023-03-19  6:43 ` [PATCH 1/2] git-compat-util: time_now " Paul Eggert
2023-03-19  6:43 ` [PATCH 2/2] git-compat-util: use gettimeofday " Paul Eggert
2023-03-19 19:34   ` Eric Wong
2023-03-20 16:33     ` Junio C Hamano
2023-03-20 17:01       ` Junio C Hamano
2023-03-20 19:00         ` Paul Eggert
2023-03-20 19:40           ` Junio C Hamano
2023-03-20 20:36             ` Taylor Blau
2023-03-20 20:35       ` Taylor Blau
2023-03-20 23:05 ` [PATCH v2] git-compat-util: use gettimeofday(2) for time(2) Junio C Hamano
2023-03-20 23:21   ` Paul Eggert
2023-03-21 16:20     ` Junio C Hamano
2023-03-21 17:44   ` Konstantin Khomoutov
2023-03-21 18:22     ` Junio C Hamano
2023-03-21 18:22   ` Jeff King
2023-03-21 19:06     ` Taylor Blau [this message]
2023-03-21 20:04     ` Junio C Hamano
2023-03-22 17:11       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBoAQFCWGhwIO963@nand.local \
    --to=me@ttaylorr.com \
    --cc=e@80x24.org \
    --cc=eggert@cs.ucla.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).