issues(?) installing git-lfs via fedora "dnf" command

issues(?) installing git-lfs via fedora "dnf" command

[Robert P. J. Day]

  first, i realize this is almost entirely a fedora packaging issue
and i'm planning on reporting it there, but i just want to make sure
i'm not doing something stupid.

  knowing nothing about the git-lfs package, i thought i would install
it and just poke around out of sheer curiosity, so on my fully-updated
fedora 28 system, i ran:

  $ sudo dnf install git-lfs

which did in fact install that package, but also generated (abridged
version):

  ... snip ...
  Running transaction
    Preparing        :
    Installing       : git-lfs-2.4.0-1.fc28.x86_64
    Running scriptlet: git-lfs-2.4.0-1.fc28.x86_64
  Error: Failed to call git rev-parse --git-dir --show-toplevel: "fatal:
  not a git repository (or any of the parent directories): .git\n"

  Git LFS initialized.
    Verifying        : git-lfs-2.4.0-1.fc28.x86_64

  Installed:
    git-lfs.x86_64 2.4.0-1.fc28

is one supposed to be *in* a git repository when installing, because i
was in fact at the top level of my linux kernel source repo, so i'm
unclear on what that "Error" is trying to tell me. am i just being
clueless? is this something that i should submit as a fedora packaging
issue?

rday

Re: issues(?) installing git-lfs via fedora "dnf" command

[Jonathan Nieder]

Robert P. J. Day wrote:

>   $ sudo dnf install git-lfs
[...]
>   Running transaction
>     Preparing        :
>     Installing       : git-lfs-2.4.0-1.fc28.x86_64
>     Running scriptlet: git-lfs-2.4.0-1.fc28.x86_64
>   Error: Failed to call git rev-parse --git-dir --show-toplevel: "fatal:
>   not a git repository (or any of the parent directories): .git\n"
[...]
> is one supposed to be *in* a git repository when installing, because i
> was in fact at the top level of my linux kernel source repo, so i'm
> unclear on what that "Error" is trying to tell me. am i just being
> clueless? is this something that i should submit as a fedora packaging
> issue?

Yes, this looks like something that should be reported as a Fedora
packaging issue.

The packager should be able to find out whether it's an issue in
git-lfs upstream and report it to that project if it is.  Git-lfs is
not part of git.git; it's a separate project:
https://github.com/git-lfs/git-lfs/blob/master/CONTRIBUTING.md
I believe they use github's issue tracker to track bugs.

Thanks,
Jonathan

Re: issues(?) installing git-lfs via fedora "dnf" command

[Robert P. J. Day]

On Mon, 21 May 2018, Jonathan Nieder wrote:

> Robert P. J. Day wrote:
>
> >   $ sudo dnf install git-lfs
> [...]
> >   Running transaction
> >     Preparing        :
> >     Installing       : git-lfs-2.4.0-1.fc28.x86_64
> >     Running scriptlet: git-lfs-2.4.0-1.fc28.x86_64
> >   Error: Failed to call git rev-parse --git-dir --show-toplevel: "fatal:
> >   not a git repository (or any of the parent directories): .git\n"
> [...]
> > is one supposed to be *in* a git repository when installing, because i
> > was in fact at the top level of my linux kernel source repo, so i'm
> > unclear on what that "Error" is trying to tell me. am i just being
> > clueless? is this something that i should submit as a fedora packaging
> > issue?
>
> Yes, this looks like something that should be reported as a Fedora
> packaging issue.
>
> The packager should be able to find out whether it's an issue in
> git-lfs upstream and report it to that project if it is.  Git-lfs is
> not part of git.git; it's a separate project:
> https://github.com/git-lfs/git-lfs/blob/master/CONTRIBUTING.md
> I believe they use github's issue tracker to track bugs.

  it would *appear* that this is a combination of both a git issue,
and a red hat packaging issue:

https://bugzilla.redhat.com/show_bug.cgi?id=1580357
https://github.com/git-lfs/git-lfs/issues/3013

rday

Re: issues(?) installing git-lfs via fedora "dnf" command

[Jonathan Nieder]

Hi,

Robert P. J. Day wrote:
> On Mon, 21 May 2018, Jonathan Nieder wrote:

>> The packager should be able to find out whether it's an issue in
>> git-lfs upstream and report it to that project if it is.  Git-lfs is
>> not part of git.git; it's a separate project:
>> https://github.com/git-lfs/git-lfs/blob/master/CONTRIBUTING.md
>> I believe they use github's issue tracker to track bugs.
>
>   it would *appear* that this is a combination of both a git issue,
> and a red hat packaging issue:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1580357
> https://github.com/git-lfs/git-lfs/issues/3013

Can you clarify?  Neither of those bugs points to a git issue if I
understand correctly.  They may be a git-lfs issue, though.

This kind of confusion is exactly why the Git project adopted a
trademark policy to prevent outside projects from identifying
themselves with Git: https://git-scm.com/about/trademark.
Unfortunately Git LFS's existence precedes that policy.  I believe
they got permission to continue using the name, confusing as it is.

Thanks,
Jonathan

Re: issues(?) installing git-lfs via fedora "dnf" command

[Robert P. J. Day]

On Mon, 21 May 2018, Jonathan Nieder wrote:

> Hi,
>
> Robert P. J. Day wrote:
> > On Mon, 21 May 2018, Jonathan Nieder wrote:
>
> >> The packager should be able to find out whether it's an issue in
> >> git-lfs upstream and report it to that project if it is.  Git-lfs is
> >> not part of git.git; it's a separate project:
> >> https://github.com/git-lfs/git-lfs/blob/master/CONTRIBUTING.md
> >> I believe they use github's issue tracker to track bugs.
> >
> >   it would *appear* that this is a combination of both a git issue,
> > and a red hat packaging issue:
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1580357
> > https://github.com/git-lfs/git-lfs/issues/3013
>
> Can you clarify?  Neither of those bugs points to a git issue if I
> understand correctly.  They may be a git-lfs issue, though.

  sorry, i mistyped, i should have said a "git-lfs issue".

rday