From: Derrick Stolee <stolee@gmail.com>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Cc: Emily Shaffer <emilyshaffer@google.com>
Subject: Re: [PATCH 3/5] make git-bugreport a builtin
Date: Thu, 13 Aug 2020 13:01:42 -0400 [thread overview]
Message-ID: <f576fdce-9005-4653-3f91-0ddd2fff125d@gmail.com> (raw)
In-Reply-To: <20200813145936.GC891370@coredump.intra.peff.net>
On 8/13/2020 10:59 AM, Jeff King wrote:
> There's no reason that bugreport has to be a separate binary. And since
> it links against libgit.a, it has a rather large disk footprint. Let's
> make it a builtin, which reduces the size of a stripped installation
> from 24MB to 22MB.
>
> This also simplifies our Makefile a bit. And we can take advantage of
> builtin niceties like RUN_SETUP_GENTLY.
I agree that this is a good change. I'm a bit surprised that a
feature added so recently wasn't added as a builtin in the first
place. Perhaps that was a conscious decision? Maybe it was just
because there was some point in time where it might have been
relegated to contrib.
Thanks,
-Stolee
next prev parent reply other threads:[~2020-08-13 17:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 14:55 [PATCH 0/5] slimming down installed size Jeff King
2020-08-13 14:57 ` [PATCH 1/5] Makefile: drop builtins from MSVC pdb list Jeff King
2020-08-13 15:04 ` Taylor Blau
2020-08-13 15:08 ` Jeff King
2020-08-13 16:37 ` Derrick Stolee
2020-08-13 17:40 ` Jeff King
2020-08-14 14:18 ` Johannes Schindelin
2020-08-14 14:32 ` Jeff King
2020-08-17 4:42 ` Johannes Schindelin
2020-08-17 13:20 ` Jeff Hostetler
2020-08-13 14:58 ` [PATCH 2/5] make credential helpers builtins Jeff King
2020-08-13 15:08 ` Taylor Blau
2020-08-13 15:14 ` Jeff King
2020-08-13 17:55 ` Junio C Hamano
2020-08-13 14:59 ` [PATCH 3/5] make git-bugreport a builtin Jeff King
2020-08-13 17:01 ` Derrick Stolee [this message]
2020-08-13 17:38 ` Jeff King
2020-08-13 18:25 ` Junio C Hamano
2020-08-13 18:47 ` Junio C Hamano
2020-08-14 10:13 ` Jeff King
2020-08-14 14:25 ` Johannes Schindelin
2020-08-14 10:05 ` Jeff King
2020-08-13 18:01 ` Junio C Hamano
2020-08-14 14:28 ` Johannes Schindelin
2020-08-15 6:38 ` Jeff King
2020-08-17 12:12 ` Emily Shaffer
2020-08-17 16:58 ` Junio C Hamano
2020-08-17 21:40 ` Jeff King
2020-08-17 12:16 ` Emily Shaffer
2020-08-13 14:59 ` [PATCH 4/5] make git-fast-import " Jeff King
2020-08-13 15:00 ` [PATCH 5/5] drop vcs-svn experiment Jeff King
2020-08-13 15:11 ` Taylor Blau
2020-08-13 15:18 ` Jeff King
2020-08-14 14:39 ` Johannes Schindelin
2020-08-14 15:11 ` Jeff King
2020-08-13 15:13 ` [PATCH 0/5] slimming down installed size Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f576fdce-9005-4653-3f91-0ddd2fff125d@gmail.com \
--to=stolee@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).