* [PATCH] t8005: use egrep when extended regular expressions are required
@ 2009-05-06 18:31 Brandon Casey
2009-05-06 18:48 ` Junio C Hamano
2009-05-07 0:12 ` Nguyen Thai Ngoc Duy
0 siblings, 2 replies; 3+ messages in thread
From: Brandon Casey @ 2009-05-06 18:31 UTC (permalink / raw)
To: gitster; +Cc: pclouds, git
Not all versions of grep understand backslashed extended regular
expressions. Possibly only gnu grep does.
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
t/t8005-blame-i18n.sh | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t8005-blame-i18n.sh b/t/t8005-blame-i18n.sh
index 4470a92..fcd5c26 100755
--- a/t/t8005-blame-i18n.sh
+++ b/t/t8005-blame-i18n.sh
@@ -36,7 +36,7 @@ EOF
test_expect_success \
'blame respects i18n.commitencoding' '
git blame --incremental file | \
- grep "^\(author\|summary\) " > actual &&
+ egrep "^(author|summary) " > actual &&
test_cmp actual expected
'
@@ -53,7 +53,7 @@ test_expect_success \
'blame respects i18n.logoutputencoding' '
git config i18n.logoutputencoding cp1251 &&
git blame --incremental file | \
- grep "^\(author\|summary\) " > actual &&
+ egrep "^(author|summary) " > actual &&
test_cmp actual expected
'
@@ -69,7 +69,7 @@ EOF
test_expect_success \
'blame respects --encoding=utf-8' '
git blame --incremental --encoding=utf-8 file | \
- grep "^\(author\|summary\) " > actual &&
+ egrep "^(author|summary) " > actual &&
test_cmp actual expected
'
@@ -85,7 +85,7 @@ EOF
test_expect_success \
'blame respects --encoding=none' '
git blame --incremental --encoding=none file | \
- grep "^\(author\|summary\) " > actual &&
+ egrep "^(author|summary) " > actual &&
test_cmp actual expected
'
--
1.6.2.4.24.gde59d2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] t8005: use egrep when extended regular expressions are required
2009-05-06 18:31 [PATCH] t8005: use egrep when extended regular expressions are required Brandon Casey
@ 2009-05-06 18:48 ` Junio C Hamano
2009-05-07 0:12 ` Nguyen Thai Ngoc Duy
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2009-05-06 18:48 UTC (permalink / raw)
To: Brandon Casey; +Cc: gitster, pclouds, git
Brandon Casey <casey@nrlssc.navy.mil> writes:
> Not all versions of grep understand backslashed extended regular
> expressions. Possibly only gnu grep does.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] t8005: use egrep when extended regular expressions are required
2009-05-06 18:31 [PATCH] t8005: use egrep when extended regular expressions are required Brandon Casey
2009-05-06 18:48 ` Junio C Hamano
@ 2009-05-07 0:12 ` Nguyen Thai Ngoc Duy
1 sibling, 0 replies; 3+ messages in thread
From: Nguyen Thai Ngoc Duy @ 2009-05-07 0:12 UTC (permalink / raw)
To: Brandon Casey; +Cc: gitster, git
On Thu, May 7, 2009 at 4:31 AM, Brandon Casey <casey@nrlssc.navy.mil> wrote:
> Not all versions of grep understand backslashed extended regular
> expressions. Possibly only gnu grep does.
>
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Works for me.
--
Duy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-07 0:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-06 18:31 [PATCH] t8005: use egrep when extended regular expressions are required Brandon Casey
2009-05-06 18:48 ` Junio C Hamano
2009-05-07 0:12 ` Nguyen Thai Ngoc Duy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).