git-gui bugs due to dependency on system Wish on MacOS

git-gui bugs due to dependency on system Wish on MacOS

[Glen Choo]

Hi! We've received reports that git-gui is showing black windows upon
upgrading to MacOS Monterey. It seems to be the same issue as [1], but
somehow it's only appeared for our users on Monterey and not Mojave.

TKFRAMEWORK = /Library/Frameworks/Tk.framework/Resources/Wish.app

* Github Issue https://github.com/Homebrew/homebrew-core/issues/39987
* git-gui formula https://formulae.brew.sh/formula/git-gui

$ brew install tcl-tk
$ PATH=/usr/local/opt/tcl-tk/bin:$PATH # This contains wish
$ cd /path/to/git/git-gui/
$ ./git-gui.sh

[1] https://github.com/prati0100/git-gui/issues/48
That said, Homebrew seems to have worked around this problem altogether
by including their own Tcl/Tk dependency.

I dug a little deeper and I was able to fix the theming issues by using
a different version of wish:

Note that I had to call git-gui.sh because that's the only entrypoint
that doesn't use the system Wish referenced in the Makefile.

Is this a fix that we should make in the git-gui project?

Re: git-gui bugs due to dependency on system Wish on MacOS

[Glen Choo]

It looks like the previous message's formatting got messed up somehow...
the correct formatting is below:

Hi! We've received reports that git-gui is showing black windows upon
upgrading to MacOS Monterey. It seems to be the same issue as [1], but
somehow it's only appeared for our users on Monterey and not Mojave.

I dug a little deeper and I was able to fix the theming issues by using
a different version of wish:

  $ brew install tcl-tk
  $ PATH=/usr/local/opt/tcl-tk/bin:$PATH # This contains wish
  $ cd /path/to/git/git-gui/
  $ ./git-gui.sh

Note that I had to call git-gui.sh because that's the only entrypoint
that doesn't use the system Wish referenced in the Makefile:

  TKFRAMEWORK = /Library/Frameworks/Tk.framework/Resources/Wish.app

That said, Homebrew seems to have worked around this problem altogether
by including their own Tcl/Tk dependency.

* Github Issue https://github.com/Homebrew/homebrew-core/issues/39987
* git-gui formula https://formulae.brew.sh/formula/git-gui

Is this a fix that we should make in the git-gui project?

[1] https://github.com/prati0100/git-gui/issues/48