From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Cc: git <git@vger.kernel.org>,
"brian m . carlson" <sandals@crustytoothpaste.net>,
Johannes Sixt <j6t@kdbg.org>,
Jonathan Tan <jonathantanmy@google.com>,
Jeff King <peff@peff.net>,
Christian Couder <christian.couder@gmail.com>,
Fredrik Kuivinen <frekui@gmail.com>
Subject: Re: [PATCH v2 2/2] hex: make hash_to_hex_algop() and friends thread-safe
Date: Mon, 10 Aug 2020 16:15:13 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2008101613440.50@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <CAHd-oW6mvaANTBX5sVEi49s_Ku71-ZXqhyePtkwbCKaTK7tm4Q@mail.gmail.com>
Hi Matheus,
On Sat, 18 Jul 2020, Matheus Tavares Bernardino wrote:
> On Thu, Jul 16, 2020 at 9:56 AM Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>
> Alternatively, if using thread-local storage is still an option, I
> think I might have solved the problems we had in the previous
> iteration with memory leaks on Windows. I changed our
> pthread_key_create() emulation to start using the destructor callback
> on Windows, through the Fiber Local Storage (FLS) API. As the
> documentation says [1] "If no fiber switching occurs, FLS acts exactly
> the same as thread local storage". The advantage over TLS is that
> FLSAlloc() does take a callback parameter.
Okay, but I am still not so enthusiastic. We can fix this in a much
simpler way, I believe, than introducing the first thread-local storage
user. Let's leave TLS until the time we actually need it?
Ciao,
Dscho
next prev parent reply other threads:[~2020-08-10 14:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 22:29 [RFC] Thread safety in some low-level functions Matheus Tavares Bernardino
2020-06-24 22:52 ` Matheus Tavares Bernardino
2020-06-25 1:38 ` brian m. carlson
2020-06-25 20:32 ` [PATCH 0/2] Make oid_to_hex() thread-safe Matheus Tavares
2020-06-25 20:32 ` [PATCH 1/2] compat/win32/pthread: add pthread_once() Matheus Tavares
2020-06-26 5:45 ` Christian Couder
2020-06-26 14:13 ` Matheus Tavares Bernardino
2020-06-25 20:32 ` [PATCH 2/2] hex: make hash_to_hex_algop() and friends thread-safe Matheus Tavares
2020-06-25 23:07 ` brian m. carlson
2020-06-25 23:54 ` Matheus Tavares Bernardino
2020-06-26 0:00 ` Matheus Tavares Bernardino
2020-06-26 6:02 ` Christian Couder
2020-06-26 8:22 ` [PATCH 0/2] Make oid_to_hex() thread-safe Christian Couder
2020-06-26 16:22 ` Matheus Tavares Bernardino
2020-06-26 21:54 ` [PATCH v2 " Matheus Tavares
2020-06-26 21:54 ` [PATCH v2 1/2] compat/win32/pthread: add pthread_once() Matheus Tavares
2020-06-26 21:54 ` [PATCH v2 2/2] hex: make hash_to_hex_algop() and friends thread-safe Matheus Tavares
2020-06-29 15:11 ` Johannes Schindelin
2020-06-30 20:37 ` Matheus Tavares Bernardino
2020-07-01 11:32 ` Johannes Schindelin
2020-07-16 11:29 ` Johannes Schindelin
2020-07-18 3:09 ` Matheus Tavares Bernardino
2020-08-10 14:15 ` Johannes Schindelin [this message]
2020-07-18 3:52 ` Matheus Tavares
2020-07-26 17:41 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2008101613440.50@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=christian.couder@gmail.com \
--cc=frekui@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jonathantanmy@google.com \
--cc=matheus.bernardino@usp.br \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).