* [PATCH] t/README: fix typo
@ 2022-01-04 23:17 Marc Strapetz via GitGitGadget
2022-01-05 16:22 ` Johannes Schindelin
2022-01-05 20:41 ` Junio C Hamano
0 siblings, 2 replies; 6+ messages in thread
From: Marc Strapetz via GitGitGadget @ 2022-01-04 23:17 UTC (permalink / raw)
To: git; +Cc: Marc Strapetz, Marc Strapetz
From: Marc Strapetz <marc.strapetz@syntevo.com>
Signed-off-by: Marc Strapetz <marc.strapetz@syntevo.com>
---
t/README: fix typo
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1110%2Fmstrap%2Ffeature%2FREADME-typo-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1110/mstrap/feature/README-typo-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1110
t/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/README b/t/README
index 2353a4c5e13..f48e0542cdc 100644
--- a/t/README
+++ b/t/README
@@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is
complete or needs to be abandoned for whatever reason (in which case the
migrated codepaths still retain their performance benefits).
-GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of
+GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of
prereqs that are required to succeed. If a prereq in this list is triggered by
a test and then fails then the whole test run will abort. This can help to make
sure the expected tests are executed and not silently skipped when their
base-commit: dcc0cd074f0c639a0df20461a301af6d45bd582e
--
gitgitgadget
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] t/README: fix typo
2022-01-04 23:17 [PATCH] t/README: fix typo Marc Strapetz via GitGitGadget
@ 2022-01-05 16:22 ` Johannes Schindelin
2022-01-05 16:47 ` Marc Strapetz
2022-01-05 20:41 ` Junio C Hamano
1 sibling, 1 reply; 6+ messages in thread
From: Johannes Schindelin @ 2022-01-05 16:22 UTC (permalink / raw)
To: Marc Strapetz via GitGitGadget; +Cc: git, Marc Strapetz, Marc Strapetz
Hi Marc,
On Tue, 4 Jan 2022, Marc Strapetz via GitGitGadget wrote:
> From: Marc Strapetz <marc.strapetz@syntevo.com>
>
> Signed-off-by: Marc Strapetz <marc.strapetz@syntevo.com>
> ---
> t/README: fix typo
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1110%2Fmstrap%2Ffeature%2FREADME-typo-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1110/mstrap/feature/README-typo-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1110
>
> t/README | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/README b/t/README
> index 2353a4c5e13..f48e0542cdc 100644
> --- a/t/README
> +++ b/t/README
> @@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is
> complete or needs to be abandoned for whatever reason (in which case the
> migrated codepaths still retain their performance benefits).
>
> -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of
> +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of
Good find!
I'm curious, how did you find it? If it was a spell checker, did it also
find the "dotsh" typo in the same file (it should be "dots", I think)?
Ciao,
Dscho
> prereqs that are required to succeed. If a prereq in this list is triggered by
> a test and then fails then the whole test run will abort. This can help to make
> sure the expected tests are executed and not silently skipped when their
>
> base-commit: dcc0cd074f0c639a0df20461a301af6d45bd582e
> --
> gitgitgadget
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] t/README: fix typo
2022-01-05 16:22 ` Johannes Schindelin
@ 2022-01-05 16:47 ` Marc Strapetz
2022-01-06 6:17 ` Marc Strapetz
0 siblings, 1 reply; 6+ messages in thread
From: Marc Strapetz @ 2022-01-05 16:47 UTC (permalink / raw)
To: Johannes Schindelin, Marc Strapetz via GitGitGadget; +Cc: git
Hi Dscho,
On 05/01/2022 17:22, Johannes Schindelin wrote:
>> @@ -466,7 +466,7 @@ explicitly providing repositories when accessing submodule objects is
>> complete or needs to be abandoned for whatever reason (in which case the
>> migrated codepaths still retain their performance benefits).
>>
>> -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of
>> +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of
>
> Good find!
>
> I'm curious, how did you find it? If it was a spell checker, did it also
I found it by plain reading :) as I had troubles to get a test working.
> find the "dotsh" typo in the same file (it should be "dots", I think)?
I wouldn't have noticed that, but I agree that it should be
"test_name_without_dots".
-Marc
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] t/README: fix typo
2022-01-04 23:17 [PATCH] t/README: fix typo Marc Strapetz via GitGitGadget
2022-01-05 16:22 ` Johannes Schindelin
@ 2022-01-05 20:41 ` Junio C Hamano
1 sibling, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2022-01-05 20:41 UTC (permalink / raw)
To: Marc Strapetz via GitGitGadget; +Cc: git, Marc Strapetz
"Marc Strapetz via GitGitGadget" <gitgitgadget@gmail.com> writes:
> -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated list of
> +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated list of
Thanks, queued.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] t/README: fix typo
2022-01-05 16:47 ` Marc Strapetz
@ 2022-01-06 6:17 ` Marc Strapetz
2022-01-06 17:48 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Marc Strapetz @ 2022-01-06 6:17 UTC (permalink / raw)
To: Johannes Schindelin, Marc Strapetz via GitGitGadget; +Cc: git
On 05/01/2022 17:47, Marc Strapetz wrote:
> Hi Dscho,
>
> On 05/01/2022 17:22, Johannes Schindelin wrote:
>>> @@ -466,7 +466,7 @@ explicitly providing repositories when accessing
>>> submodule objects is
>>> complete or needs to be abandoned for whatever reason (in which
>>> case the
>>> migrated codepaths still retain their performance benefits).
>>>
>>> -GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space speparated
>>> list of
>>> +GIT_TEST_REQUIRE_PREREQ=<list> allows specifying a space separated
>>> list of
>>
>> Good find!
>>
>> I'm curious, how did you find it? If it was a spell checker, did it also
>
> I found it by plain reading :) as I had troubles to get a test working.
>
> > find the "dotsh" typo in the same file (it should be "dots", I think)?
>
> I wouldn't have noticed that, but I agree that it should be
> "test_name_without_dots".
Please disregard my last statement. "test_name_without_dotsh" means
"test name without .sh extension". For
"t2109-update-index-index-version.sh", the directory will be "trash
directory.t2109-update-index-index-version".
-Marc
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] t/README: fix typo
2022-01-06 6:17 ` Marc Strapetz
@ 2022-01-06 17:48 ` Junio C Hamano
0 siblings, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2022-01-06 17:48 UTC (permalink / raw)
To: Marc Strapetz; +Cc: Johannes Schindelin, Marc Strapetz via GitGitGadget, git
Marc Strapetz <marc.strapetz@syntevo.com> writes:
>> > find the "dotsh" typo in the same file (it should be "dots", I
>> think)?
>> I wouldn't have noticed that, but I agree that it should be
>> "test_name_without_dots".
>
> Please disregard my last statement. "test_name_without_dotsh" means
> "test name without .sh extension". For
> "t2109-update-index-index-version.sh", the directory will be "trash
> directory.t2109-update-index-index-version".
Yup. "without_dot_sh" might have been a better way to spell it, but
"without_dotsh" certainly is better than "without_dots".
Thanks for being extra careful. In any case, the original fix is
good and has already been queued.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-06 17:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 23:17 [PATCH] t/README: fix typo Marc Strapetz via GitGitGadget
2022-01-05 16:22 ` Johannes Schindelin
2022-01-05 16:47 ` Marc Strapetz
2022-01-06 6:17 ` Marc Strapetz
2022-01-06 17:48 ` Junio C Hamano
2022-01-05 20:41 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).