From: Brandon Casey <casey@nrlssc.navy.mil>
To: "Tom G. Christensen" <tgc@statsbiblioteket.dk>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH FYI] t9700/test.pl: backwards compatibility improvements
Date: Mon, 15 Sep 2008 11:20:08 -0500 [thread overview]
Message-ID: <ryvGcG_Sg9kftPIp7uWA1JVCd0inSiqB61VnfUuxRUZJg6W7SWhmOQ@cipher.nrlssc.navy.mil> (raw)
In-Reply-To: <48CE4CFE.1010106@statsbiblioteket.dk>
Tom G. Christensen wrote:
> Brandon Casey wrote:
>> Some versions of perl complain when 'STDERR' is used as the third
>> argument
>> in the 3-argument form of open(). Convert to the 2-argument form which is
>> described for duping STDERR in my second edition camel book.
>>
>> The object oriented version of File::Temp is a rather new incarnation it
>> seems. The File::Temp man page for v5.8.0 says "(NOT YET IMPLEMENTED)" in
>> the 'Objects' section. These can be converted to use
>> File::Temp::tempfile().
>>
>> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
>>
> Tested-by: Tom G. Christensen <tgc@statsbiblioteket.dk>
>
> Without this patch the testsuite will fail with perl 5.8.0:
> t9700$ ./test.pl
> ok 1 - use Git;
> Bareword "STDERR" not allowed while "strict subs" in use at ./test.pl
> line 41.
> Execution of ./test.pl aborted due to compilation errors.
> 1..1
> # Looks like your test died just after 1.
>
>
> Could we please get this patch in?
Junio had asked me to follow up on that patch at a later time, so
thanks for prodding.
Here is an alternative which _removes_ the File::Temp requirement.
-brandon
next prev parent reply other threads:[~2008-09-15 16:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 23:39 [FYI] How I compile on SunOS 5.7 with the SUNWspro compiler and ksh Brandon Casey
2008-08-18 23:55 ` [PATCH] Makefile: configuration for SunOS 5.7 Brandon Casey
2008-08-18 23:57 ` [PATCH] dir.c: avoid c99 array initialization Brandon Casey
2008-08-28 15:32 ` David Kågedal
2008-08-28 15:41 ` Andreas Ericsson
2008-08-28 16:45 ` Brandon Casey
2008-08-28 18:50 ` Junio C Hamano
2008-08-28 21:01 ` Brandon Casey
2008-08-28 21:12 ` Alex Riesen
2008-08-28 21:45 ` Brandon Casey
2008-08-28 20:01 ` Alex Riesen
2008-08-28 20:16 ` Shawn O. Pearce
2008-08-28 20:21 ` Junio C Hamano
2008-08-28 22:47 ` [PATCH v2] dir.c: Avoid " Brandon Casey
2008-08-28 22:56 ` Alex Riesen
2008-08-28 23:03 ` Brandon Casey
2008-08-28 20:27 ` [PATCH] dir.c: avoid " Alex Riesen
2008-08-29 11:08 ` Johannes Schindelin
2008-08-19 0:08 ` [PATCH FYI] reset,cat-file: remove const declaration from array Brandon Casey
2008-08-19 0:11 ` [PATCH FYI] test-lib.sh: work around ksh's trap shortcomings Brandon Casey
2008-08-19 0:13 ` [PATCH FYI] t1002-read-tree-m-u-2way.sh: use 'git diff -U0' rather than 'diff -U0' Brandon Casey
2008-08-19 0:18 ` [PATCH FYI] Work around sed issues Brandon Casey
2008-08-19 0:20 ` [PATCH FYI] t9301-fast-export.sh: don't unset config variable while we're skipping test 4 Brandon Casey
2008-08-19 0:20 ` [FYI] How I compile on SunOS 5.7 with the SUNWspro compiler and ksh Jeff King
2008-08-19 0:47 ` Brandon Casey
2008-08-19 2:01 ` Jeff King
2008-08-19 0:22 ` [PATCH FYI] t9700/test.pl: backwards compatibility improvements Brandon Casey
2008-09-15 11:54 ` Tom G. Christensen
2008-09-15 16:20 ` Brandon Casey [this message]
2008-09-15 16:32 ` Brandon Casey
2008-09-15 16:20 ` [PATCH 1/3] t9700/test.pl: no longer requires File::Basename Brandon Casey
2008-09-15 16:23 ` [PATCH 2/3] t9700/test.pl: avoid bareword 'STDERR' in 3-argument open() Brandon Casey
2008-09-15 16:25 ` [PATCH 3/3] t9700/test.pl: remove File::Temp requirement Brandon Casey
2008-09-15 18:27 ` Tom G. Christensen
2008-08-19 6:13 ` [FYI] How I compile on SunOS 5.7 with the SUNWspro compiler and ksh Alex Riesen
2008-08-19 15:42 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ryvGcG_Sg9kftPIp7uWA1JVCd0inSiqB61VnfUuxRUZJg6W7SWhmOQ@cipher.nrlssc.navy.mil \
--to=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=tgc@statsbiblioteket.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).