* [PATCHv3] Makefile: add missing phony target
@ 2015-12-15 15:21 Elia Pinto
2015-12-16 8:25 ` Matthieu Moy
0 siblings, 1 reply; 2+ messages in thread
From: Elia Pinto @ 2015-12-15 15:21 UTC (permalink / raw)
To: git; +Cc: Matthieu.Moy, Elia Pinto
Add some missing phony target to Makefile.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Helped-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
---
This is the third version of this patch.
Compared to the previous I have added only the missing phony
target as suggested by Matthieu Moy
Makefile | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Makefile b/Makefile
index fd19b54..fc2f1ab 100644
--- a/Makefile
+++ b/Makefile
@@ -2025,6 +2025,7 @@ $(VCSSVN_LIB): $(VCSSVN_OBJS)
export DEFAULT_EDITOR DEFAULT_PAGER
+.PHONY: doc man html info pdf
doc:
$(MAKE) -C Documentation all
@@ -2068,6 +2069,7 @@ po/git.pot: $(GENERATED_H) FORCE
$(LOCALIZED_PERL)
mv $@+ $@
+.PHONY: pot
pot: po/git.pot
POFILES := $(wildcard po/*.po)
@@ -2277,6 +2279,7 @@ mergetools_instdir_SQ = $(subst ','\'',$(mergetools_instdir))
install_bindir_programs := $(patsubst %,%$X,$(BINDIR_PROGRAMS_NEED_X)) $(BINDIR_PROGRAMS_NO_X)
+.PHONY: profile-install profile-fast-install
profile-install: profile
$(MAKE) install
@@ -2343,6 +2346,8 @@ endif
done && \
./check_bindir "z$$bindir" "z$$execdir" "$$bindir/git-add$X"
+.PHONY: install-gitweb install-doc install-man install-html install-info install-pdf
+.PHONY: quick-install-doc quick-install-man quick-install-html
install-gitweb:
$(MAKE) -C gitweb install
@@ -2402,6 +2407,7 @@ rpm: dist
htmldocs = git-htmldocs-$(GIT_VERSION)
manpages = git-manpages-$(GIT_VERSION)
+.PHONY: dist-doc distclean
dist-doc:
$(RM) -r .doc-tmp-dir
mkdir .doc-tmp-dir
@@ -2470,6 +2476,8 @@ ALL_COMMANDS += git
ALL_COMMANDS += gitk
ALL_COMMANDS += gitweb
ALL_COMMANDS += git-gui git-citool
+
+.PHONY: check-docs
check-docs::
@(for v in $(ALL_COMMANDS); \
do \
@@ -2514,6 +2522,7 @@ check-builtins::
### Test suite coverage testing
#
.PHONY: coverage coverage-clean coverage-compile coverage-test coverage-report
+.PHONY: coverage-untested-functions cover_db cover_db_html
.PHONY: coverage-clean-results
coverage:
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv3] Makefile: add missing phony target
2015-12-15 15:21 [PATCHv3] Makefile: add missing phony target Elia Pinto
@ 2015-12-16 8:25 ` Matthieu Moy
0 siblings, 0 replies; 2+ messages in thread
From: Matthieu Moy @ 2015-12-16 8:25 UTC (permalink / raw)
To: Elia Pinto; +Cc: git
Elia Pinto <gitter.spiros@gmail.com> writes:
> Add some missing phony target to Makefile.
>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> Helped-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
> ---
> This is the third version of this patch.
Thanks. I double-checked with
grep .PHONY Makefile | sed 's/.PHONY: //; s/#.*//' | tr ' ' '\n' | sort | uniq -c | sort -n
there are no duplicate .PHONY, and all .PHONY targets are indeed .PHONY
ones, so the patch is now
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
> Compared to the previous I have added only the missing phony
> target as suggested by Matthieu Moy
Note: my comments were not meant to be an objection to the additional
refactoring. At least some of the hunks definitely made sense to me, but
they are better done in a separate patch.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-16 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-15 15:21 [PATCHv3] Makefile: add missing phony target Elia Pinto
2015-12-16 8:25 ` Matthieu Moy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).