archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <>
To: Mihir Mehta <>
Subject: Re: none
Date: Thu, 11 Oct 2018 07:19:29 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Mihir Mehta's message of "Wed, 10 Oct 2018 10:20:06 -0500")

Mihir Mehta <> writes:

> Thanks, Junio. Instead of removing that part of the patch, I opted to
> expand it to make it a little clearer (in my opinion) than it was
> before. Let me know if this works.

I am mildly negative on that change.  "Omitting both would give an
empty diff" would be understandable to anybody who understands that
an omitted end of dot-dot is substituted with HEAD *and* thinks what
range HEAD..HEAD means, so it is just an additional noise to them,
and to those who do not want to waste time on thinking, it is a
statement that reads as if "it will be an error" without saying why
it is an error.  So overall, it seems, at least to me, that the
additional text adds negative value.

So, I dunno.

  parent reply	other threads:[~2018-10-10 22:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 21:08 [PATCH] doc: fix a typo and clarify a sentence Mihir Mehta
2018-10-05  6:20 ` Junio C Hamano
2018-10-10 15:20   ` Mihir Mehta
2018-10-10 15:20     ` [PATCH] doc: fix a typo and clarify a sentence Mihir Mehta
2018-10-10 22:19     ` Junio C Hamano [this message]
2018-10-10 22:26       ` Mihir Mehta
2018-10-10 23:27         ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2023-10-16 18:43 Dorcas Litunya
2023-10-17 20:21 ` none Junio C Hamano
2019-11-20  3:49 Han-Wen Nienhuys
2019-11-20  4:52 ` none Junio C Hamano
2019-11-20  5:00   ` none Han-Wen Nienhuys
2019-03-03 13:20 [PATCH 1/3] test functions: Add new function `test_file_not_empty` Junio C Hamano
2019-03-03 13:29 ` Rohit Ashiwal
2019-03-03 13:33   ` none Junio C Hamano
2016-04-11 19:04 (unknown), miwilliams
2016-04-11 19:18 ` none Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).