From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Enzo Matsumiya <ematsumiya@suse.de>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v3 1/2] run-command API: rename "env_array" to "env"
Date: Thu, 02 Jun 2022 17:37:25 -0700 [thread overview]
Message-ID: <xmqqczfqinui.fsf@gitster.g> (raw)
In-Reply-To: patch-v3-1.2-80ef05d5b0a-20220602T090745Z-avarab@gmail.com
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> The rest of this is all a result of applying [1]:
>
> * make contrib/coccinelle/run_command.cocci.patch
> * patch -p1 <contrib/coccinelle/run_command.cocci.patch
> * git add -u
>
> 1. cat contrib/coccinelle/run_command.pending.cocci
> @@
> struct child_process E;
> @@
> - E.env_array
> + E.env
>
> @@
> struct child_process *E;
> @@
> - E->env_array
> + E->env
It makes sense to have this in the log message for documentation
purposes. We have plenty of examples of renaming a symbol to
another, like the simple ones in object_id.cocci, so adding this to
the collection in contrib/coccinelle would not add much value.
Will replace. Thanks.
next prev parent reply other threads:[~2022-06-03 0:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 2:32 What's cooking in git.git (Dec 2021, #04; Wed, 15) Junio C Hamano
2021-12-16 11:51 ` ab/run-command (was: What's cooking in git.git (Dec 2021, #04; Wed, 15)) Ævar Arnfjörð Bjarmason
2021-12-16 15:31 ` Jeff King
2021-12-16 15:38 ` Ævar Arnfjörð Bjarmason
2021-12-16 19:11 ` ab/run-command Junio C Hamano
2022-04-06 10:42 ` [PATCH 0/3] run-command.h: rename "env_array" to "env" Ævar Arnfjörð Bjarmason
2022-04-06 10:42 ` [PATCH 1/3] cocci: add a rename of "struct child_process"'s " Ævar Arnfjörð Bjarmason
2022-04-06 10:42 ` [PATCH 2/3] run-command API: rename " Ævar Arnfjörð Bjarmason
2022-04-06 10:42 ` [PATCH 3/3] run-command API users: use "env" not "env_array" in comments & names Ævar Arnfjörð Bjarmason
2022-04-07 12:09 ` [PATCH 0/3] run-command.h: rename "env_array" to "env" Johannes Schindelin
2022-04-07 16:48 ` Junio C Hamano
2022-04-07 17:52 ` Junio C Hamano
2022-05-20 7:24 ` [PATCH v2 0/4] " Ævar Arnfjörð Bjarmason
2022-05-20 7:24 ` [PATCH v2 1/4] cocci: add a rename of "struct child_process"'s " Ævar Arnfjörð Bjarmason
2022-05-20 7:24 ` [PATCH v2 2/4] run-command API: rename " Ævar Arnfjörð Bjarmason
2022-05-20 7:24 ` [PATCH v2 3/4] cocci: remove env_array -> env migration Ævar Arnfjörð Bjarmason
2022-05-20 7:24 ` [PATCH v2 4/4] run-command API users: use "env" not "env_array" in comments & names Ævar Arnfjörð Bjarmason
2022-05-20 16:27 ` [PATCH v2 0/4] run-command.h: rename "env_array" to "env" Junio C Hamano
2022-05-21 11:09 ` Ævar Arnfjörð Bjarmason
2022-06-02 9:09 ` [PATCH v3 0/2] " Ævar Arnfjörð Bjarmason
2022-06-02 9:09 ` [PATCH v3 1/2] run-command API: " Ævar Arnfjörð Bjarmason
2022-06-03 0:37 ` Junio C Hamano [this message]
2022-06-02 9:09 ` [PATCH v3 2/2] run-command API users: use "env" not "env_array" in comments & names Ævar Arnfjörð Bjarmason
2021-12-16 23:46 ` ab/make-dependency (was: What's cooking in git.git (Dec 2021, #04; Wed, 15)) Ævar Arnfjörð Bjarmason
2021-12-21 1:34 ` What's cooking in git.git (Dec 2021, #04; Wed, 15) Aleen 徐沛文
2021-12-21 7:30 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqczfqinui.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=ematsumiya@suse.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).