* [PATCH 0/4] *.h: remove dead function declarations
@ 2021-10-01 10:37 Ævar Arnfjörð Bjarmason
2021-10-01 10:37 ` [PATCH 1/4] builtin.h: remove cmd_tar_tree() declaration Ævar Arnfjörð Bjarmason
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2021-10-01 10:37 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Ævar Arnfjörð Bjarmason
A trivial series to remove some long-dead code, the oldest is
something we've been carrying since 2006!
Ævar Arnfjörð Bjarmason (4):
builtin.h: remove cmd_tar_tree() declaration
grep.h: remove unused grep_threads_ok() declaration
log-tree.h: remove unused function declarations
config.h: remove unused git_config_get_untracked_cache() declaration
builtin.h | 1 -
config.h | 1 -
grep.h | 1 -
log-tree.h | 2 --
4 files changed, 5 deletions(-)
--
2.33.0.1340.ge9f77250f2b
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/4] builtin.h: remove cmd_tar_tree() declaration
2021-10-01 10:37 [PATCH 0/4] *.h: remove dead function declarations Ævar Arnfjörð Bjarmason
@ 2021-10-01 10:37 ` Ævar Arnfjörð Bjarmason
2021-10-01 10:37 ` [PATCH 2/4] grep.h: remove unused grep_threads_ok() declaration Ævar Arnfjörð Bjarmason
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2021-10-01 10:37 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Ævar Arnfjörð Bjarmason
The cmd_tar_tree() function itself was removed in
925ceccf050 (tar-tree: remove deprecated command, 2013-11-10).
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
builtin.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin.h b/builtin.h
index 16ecd5586f0..8a58743ed63 100644
--- a/builtin.h
+++ b/builtin.h
@@ -225,7 +225,6 @@ int cmd_submodule__helper(int argc, const char **argv, const char *prefix);
int cmd_switch(int argc, const char **argv, const char *prefix);
int cmd_symbolic_ref(int argc, const char **argv, const char *prefix);
int cmd_tag(int argc, const char **argv, const char *prefix);
-int cmd_tar_tree(int argc, const char **argv, const char *prefix);
int cmd_unpack_file(int argc, const char **argv, const char *prefix);
int cmd_unpack_objects(int argc, const char **argv, const char *prefix);
int cmd_update_index(int argc, const char **argv, const char *prefix);
--
2.33.0.1340.ge9f77250f2b
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/4] grep.h: remove unused grep_threads_ok() declaration
2021-10-01 10:37 [PATCH 0/4] *.h: remove dead function declarations Ævar Arnfjörð Bjarmason
2021-10-01 10:37 ` [PATCH 1/4] builtin.h: remove cmd_tar_tree() declaration Ævar Arnfjörð Bjarmason
@ 2021-10-01 10:37 ` Ævar Arnfjörð Bjarmason
2021-10-01 10:37 ` [PATCH 3/4] log-tree.h: remove unused function declarations Ævar Arnfjörð Bjarmason
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2021-10-01 10:37 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Ævar Arnfjörð Bjarmason
This function was removed in 0579f91dd74 (grep: enable threading with
-p and -W using lazy attribute lookup, 2011-12-12), but not its
corresponding *.h declaration.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
grep.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/grep.h b/grep.h
index 128007db655..a68dce5dfa5 100644
--- a/grep.h
+++ b/grep.h
@@ -223,7 +223,6 @@ void grep_source_load_driver(struct grep_source *gs,
int grep_source(struct grep_opt *opt, struct grep_source *gs);
struct grep_opt *grep_opt_dup(const struct grep_opt *opt);
-int grep_threads_ok(const struct grep_opt *opt);
/*
* Mutex used around access to the attributes machinery if
--
2.33.0.1340.ge9f77250f2b
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] log-tree.h: remove unused function declarations
2021-10-01 10:37 [PATCH 0/4] *.h: remove dead function declarations Ævar Arnfjörð Bjarmason
2021-10-01 10:37 ` [PATCH 1/4] builtin.h: remove cmd_tar_tree() declaration Ævar Arnfjörð Bjarmason
2021-10-01 10:37 ` [PATCH 2/4] grep.h: remove unused grep_threads_ok() declaration Ævar Arnfjörð Bjarmason
@ 2021-10-01 10:37 ` Ævar Arnfjörð Bjarmason
2021-10-01 10:37 ` [PATCH 4/4] config.h: remove unused git_config_get_untracked_cache() declaration Ævar Arnfjörð Bjarmason
2021-10-01 21:39 ` [PATCH 0/4] *.h: remove dead function declarations Junio C Hamano
4 siblings, 0 replies; 6+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2021-10-01 10:37 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Ævar Arnfjörð Bjarmason
The init_log_tree_opt() and log_tree_opt_parse() functions were
removed in cd2bdc53094 (Common option parsing for "git log --diff" and
friends, 2006-04-14), but not their corresponding *.h declaration.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
log-tree.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/log-tree.h b/log-tree.h
index 1e8c91dbf21..e7e4641cf83 100644
--- a/log-tree.h
+++ b/log-tree.h
@@ -14,10 +14,8 @@ struct decoration_filter {
};
int parse_decorate_color_config(const char *var, const char *slot_name, const char *value);
-void init_log_tree_opt(struct rev_info *);
int log_tree_diff_flush(struct rev_info *);
int log_tree_commit(struct rev_info *, struct commit *);
-int log_tree_opt_parse(struct rev_info *, const char **, int);
void show_log(struct rev_info *opt);
void format_decorations_extended(struct strbuf *sb, const struct commit *commit,
int use_color,
--
2.33.0.1340.ge9f77250f2b
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] config.h: remove unused git_config_get_untracked_cache() declaration
2021-10-01 10:37 [PATCH 0/4] *.h: remove dead function declarations Ævar Arnfjörð Bjarmason
` (2 preceding siblings ...)
2021-10-01 10:37 ` [PATCH 3/4] log-tree.h: remove unused function declarations Ævar Arnfjörð Bjarmason
@ 2021-10-01 10:37 ` Ævar Arnfjörð Bjarmason
2021-10-01 21:39 ` [PATCH 0/4] *.h: remove dead function declarations Junio C Hamano
4 siblings, 0 replies; 6+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2021-10-01 10:37 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Ævar Arnfjörð Bjarmason
This function was removed in ad0fb659993 (repo-settings: parse
core.untrackedCache, 2019-08-13), but not its corresponding *.h entry.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
config.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/config.h b/config.h
index 147f5e0490e..7378fc165fb 100644
--- a/config.h
+++ b/config.h
@@ -609,7 +609,6 @@ int git_config_get_maybe_bool(const char *key, int *dest);
int git_config_get_pathname(const char *key, const char **dest);
int git_config_get_index_threads(int *dest);
-int git_config_get_untracked_cache(void);
int git_config_get_split_index(void);
int git_config_get_max_percent_split_change(void);
int git_config_get_fsmonitor(void);
--
2.33.0.1340.ge9f77250f2b
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/4] *.h: remove dead function declarations
2021-10-01 10:37 [PATCH 0/4] *.h: remove dead function declarations Ævar Arnfjörð Bjarmason
` (3 preceding siblings ...)
2021-10-01 10:37 ` [PATCH 4/4] config.h: remove unused git_config_get_untracked_cache() declaration Ævar Arnfjörð Bjarmason
@ 2021-10-01 21:39 ` Junio C Hamano
4 siblings, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2021-10-01 21:39 UTC (permalink / raw)
To: Ævar Arnfjörð Bjarmason; +Cc: git
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> A trivial series to remove some long-dead code, the oldest is
> something we've been carrying since 2006!
Nice. Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-01 21:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01 10:37 [PATCH 0/4] *.h: remove dead function declarations Ævar Arnfjörð Bjarmason
2021-10-01 10:37 ` [PATCH 1/4] builtin.h: remove cmd_tar_tree() declaration Ævar Arnfjörð Bjarmason
2021-10-01 10:37 ` [PATCH 2/4] grep.h: remove unused grep_threads_ok() declaration Ævar Arnfjörð Bjarmason
2021-10-01 10:37 ` [PATCH 3/4] log-tree.h: remove unused function declarations Ævar Arnfjörð Bjarmason
2021-10-01 10:37 ` [PATCH 4/4] config.h: remove unused git_config_get_untracked_cache() declaration Ævar Arnfjörð Bjarmason
2021-10-01 21:39 ` [PATCH 0/4] *.h: remove dead function declarations Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).