From: Junio C Hamano <gitster@pobox.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Teng Long via GitGitGadget <gitgitgadget@gmail.com>,
Git mailing list <git@vger.kernel.org>,
Teng Long <dyroneteng@gmail.com>,
Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH v3] clone: document partial clone section
Date: Tue, 27 Oct 2020 11:51:44 -0700 [thread overview]
Message-ID: <xmqqft5zcxj3.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <C9D6F2D9-7BA3-469D-B903-DB0B389C9166@gmail.com> (Philippe Blain's message of "Tue, 27 Oct 2020 09:13:40 -0400")
Philippe Blain <levraiphilippeblain@gmail.com> writes:
> Hi Dyrone,
>
>> Le 26 oct. 2020 à 23:12, Teng Long via GitGitGadget <gitgitgadget@gmail.com> a écrit :
>>
>> From: Dyrone Teng <dyroneteng@gmail.com>
>>
>> Partial clones are created using 'git clone', but there is no related
>> help information in the git-clone documentation during a period. Add
>> a relevant section to help users understand what partial clones are
>> and how they differ from normal clones.
>>
>> The section briefly introduces the applicable scenarios and some
>> precautions of partial clone. If users want to know more about its
>> technical design and other details, users can view the link of
>> git-partial-clone(7) according to the guidelines in the section.
>>
>> Signed-off-by: Teng Long <dyroneteng@gmail.com>
Compare this line and "From:" we see above?
They need to match.
>> ---
>> clone: document partial clone section
>>
>> Partial clones are created using 'git clone', but there is no related
>> help information in the git-clone documentation during a period. Add a
>> relevant section to help users understand what partial clones are and
>> how they differ from normal clones.
>>
>> The section briefly introduces the applicable scenarios and some
>> precautions of partial clone. If users want to know more about its
>> technical design and other details, users can view the link of
>> git-partial-clone(7) according to the guidelines in the section.
>
> Since your series has just the one patch now, you don't need to
> add a description in your GitGitGadget (GGG) PR. That's why it
> appears two times here: the text above the '---' is the commit
> message, and the text below is the PR description.
Nice. We learn new things every day---I've always wondered where
the duplicated description we sometimes see comes from.
> In the context of a one-patch series, you can use this space to
> add additional info that do not fit into the commit message, for
> example questions about your patch, etc. It is also a good idea
> (and viewed positively by reviewers) to use it to add a summary of
> what changed in your series since the last version you sent. I
> encourage you to read MyFirstContribution [1] for a good tutorial
> on the contribution process. Also, GGG understands that if you end
> your PR description with a line starting with "CC:" and an email
> address, further iterations of your series will be sent to those
> email addresses. So it would have been good to add Stolee in
> there, like this:
>
> CC: Derrick Stolee <stolee@gmail.com>
> (Junio prefers not to be directly CC'ed).
... unless it is the "final version with concensus among reviewers",
that is.
>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-745%2Fdyrone%2Fmaster-v3
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-745/dyrone/master-v3
>> Pull-Request: https://github.com/git/git/pull/745
>>
>> Range-diff vs v2:
>>
>> 1: 6f340d9aad < -: ---------- partial-clone: set default filter with --partial
>> 2: 9baf4c8ba3 < -: ---------- clone: document --partial and --filter options
>> 3: c1a44a3509 ! 1: 681c5dcb79 clone: document partial clone section
>> @@ Commit message
>> clone: document partial clone section
>>
>> Partial clones are created using 'git clone', but there is no related
>> - help information in the git-clone documentation. Add a relevant section
>> - to help users understand what partial clones are and how they differ
>> - from normal clones.
>> + help information in the git-clone documentation during a period. Add
>> + a relevant section to help users understand what partial clones are
>> + and how they differ from normal clones.
>
> It appears that you sent the same version of the patch as in v1, instead
> of the one you sent in v2 ? You had removed "during a period" for v2,
> but here it pops up again. You should check that you've sent the more
> up to date version of your patch, before sending v4.
>
> I will not comment on the patch below, since it's not the more up-to-date.
> I will send comments shortly on the v2 version by replying to [2] (the v2 version
> of your patch).
>
> Cheers,
>
> Philippe.
>
> [1] https://git-scm.com/docs/MyFirstContribution
> [2] https://lore.kernel.org/git/c1a44a35095e7d681c312ecaa07c46e49f2fae67.1586791560.git.gitgitgadget@gmail.com/
next prev parent reply other threads:[~2020-10-27 18:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 2:02 [PATCH] clone: document partial clone section Teng Long via GitGitGadget
2020-04-02 11:29 ` Derrick Stolee
2020-04-02 17:37 ` Junio C Hamano
2020-04-02 17:52 ` Derrick Stolee
2020-04-13 15:25 ` [PATCH v2 0/3] " Teng Long via GitGitGadget
2020-04-13 15:25 ` [PATCH v2 1/3] partial-clone: set default filter with --partial Derrick Stolee via GitGitGadget
2020-04-13 15:25 ` [PATCH v2 2/3] clone: document --partial and --filter options Derrick Stolee via GitGitGadget
2020-04-13 15:26 ` [PATCH v2 3/3] clone: document partial clone section Dyrone Teng via GitGitGadget
2020-10-27 13:41 ` Philippe Blain
2020-04-13 22:45 ` [PATCH v2 0/3] " Junio C Hamano
2020-04-14 13:43 ` Derrick Stolee
2020-04-14 16:25 ` Junio C Hamano
2020-04-14 16:26 ` Derrick Stolee
2020-04-14 13:42 ` Derrick Stolee
2020-10-27 3:12 ` [PATCH v3] " Teng Long via GitGitGadget
2020-10-27 13:13 ` Philippe Blain
2020-10-27 18:51 ` Junio C Hamano [this message]
2021-02-25 9:13 ` [PATCH v4] " Teng Long via GitGitGadget
2021-02-25 13:38 ` Philippe Blain
2021-03-02 14:25 ` [PATCH v5] " Teng Long via GitGitGadget
2021-03-03 19:25 ` Junio C Hamano
2021-05-06 6:27 ` Fix inconsistent signed-off-by abd author name Teng Long
2021-05-06 6:30 ` [PATCH 1/1] clone: document partial clone section Teng Long
2021-05-07 4:00 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqft5zcxj3.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=levraiphilippeblain@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).