* [PATCH] gitk: rename zh_CN.po to zh_cn.po
@ 2019-09-17 8:52 Denton Liu
2019-09-17 16:48 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Denton Liu @ 2019-09-17 8:52 UTC (permalink / raw)
To: Git Mailing List; +Cc: Paul Mackerras
When running make from a clean environment, all of the *.po files should
be converted into *.msg files. After that, when make is run without any
changes, make should not do anything.
After beffae768a (gitk: Add Chinese (zh_CN) translation, 2017-03-11),
zh_CN.po was introduced. When make was run, a zh_cn.msg file was
generated (notice the lowercase). However, since make is case-sensitive,
it expects zh_CN.po to generate a zh_CN.msg file so make will keep
reattempting to generate a zh_CN.msg so successive make invocations
result in
Generating catalog po/zh_cn.msg
msgfmt --statistics --tcl po/zh_cn.po -l zh_cn -d po/
317 translated messages.
happening continuously.
Rename zh_CN.po to zh_cn.po so that when make generates the zh_cn.msg
file, it will realize that it was successfully generated and only run
once.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
po/{zh_CN.po => zh_cn.po} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename po/{zh_CN.po => zh_cn.po} (100%)
diff --git a/po/zh_CN.po b/po/zh_cn.po
similarity index 100%
rename from po/zh_CN.po
rename to po/zh_cn.po
--
2.23.0.248.g3a9dd8fb08
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gitk: rename zh_CN.po to zh_cn.po
2019-09-17 8:52 [PATCH] gitk: rename zh_CN.po to zh_cn.po Denton Liu
@ 2019-09-17 16:48 ` Junio C Hamano
2019-09-17 22:14 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2019-09-17 16:48 UTC (permalink / raw)
To: Denton Liu; +Cc: Git Mailing List, Paul Mackerras
Denton Liu <liu.denton@gmail.com> writes:
> When running make from a clean environment, all of the *.po files should
> be converted into *.msg files. After that, when make is run without any
> changes, make should not do anything.
>
> After beffae768a (gitk: Add Chinese (zh_CN) translation, 2017-03-11),
> zh_CN.po was introduced. When make was run, a zh_cn.msg file was
> generated (notice the lowercase). However, since make is case-sensitive,
> it expects zh_CN.po to generate a zh_CN.msg file so make will keep
> reattempting to generate a zh_CN.msg so successive make invocations
> result in
>
> Generating catalog po/zh_cn.msg
> msgfmt --statistics --tcl po/zh_cn.po -l zh_cn -d po/
> 317 translated messages.
>
> happening continuously.
>
> Rename zh_CN.po to zh_cn.po so that when make generates the zh_cn.msg
> file, it will realize that it was successfully generated and only run
> once.
True, and it is not just that. The install target would fail
because it cannot find zh_CN.msg, I think.
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
> po/{zh_CN.po => zh_cn.po} | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename po/{zh_CN.po => zh_cn.po} (100%)
>
> diff --git a/po/zh_CN.po b/po/zh_cn.po
> similarity index 100%
> rename from po/zh_CN.po
> rename to po/zh_cn.po
This would make this in line with pt_{pt,br}.po, existing locales
with country code in them.
Reviewed-by: Junio C Hamano <gitster@pobox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gitk: rename zh_CN.po to zh_cn.po
2019-09-17 16:48 ` Junio C Hamano
@ 2019-09-17 22:14 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2019-09-17 22:14 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Git Mailing List, Denton Liu
Junio C Hamano <gitster@pobox.com> writes:
> This would make this in line with pt_{pt,br}.po, existing locales
> with country code in them.
>
> Reviewed-by: Junio C Hamano <gitster@pobox.com>
Paul, I've applied this to a clone of gitk locally and merged it
(resutling in 2a4ac71ffb that should be reachable from 'master'), as
it was breaking my "install" tests.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-17 22:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-17 8:52 [PATCH] gitk: rename zh_CN.po to zh_cn.po Denton Liu
2019-09-17 16:48 ` Junio C Hamano
2019-09-17 22:14 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).