* octopus merge --no-ff claims to fast-forward even though it doesn't
@ 2017-01-27 20:46 Samuel Lijin
2017-01-27 21:59 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Lijin @ 2017-01-27 20:46 UTC (permalink / raw)
To: git
I was doing an octopus merge earlier and noticed that it claims to
fast-forward when you specify --no-ff, even though it does actually
abide by --no-ff.
I can consistently reproduce as follows:
$ git clone https://github.com/sxlijin/merge-octopus-experiment
$ cd merge-octopus-experiment
$ git merge --no-ff origin/A origin/B --no-edit
Fast-forwarding to: origin/A
Trying simple merge with origin/B
Merge made by the 'octopus' strategy.
anotherA | 0
anotherB | 0
otherA | 0
otherB | 0
4 files changed, 0 insertions(+), 0 deletions(-)
create mode 100644 anotherA
create mode 100644 anotherB
create mode 100644 otherA
create mode 100644 otherB
$ git log --graph --pretty=oneline --decorate
I've reproduced the issue with 2.11.0 on both a Windows box (MSYS) and
Linux (Arch).
The issue seems to live in git-merge-octopus.sh, specifically in that
--no-ff does not affect the initial value of NON_FF_MERGE. I'm happy
to submit a patch if someone can point me in the right direction.
Sam
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: octopus merge --no-ff claims to fast-forward even though it doesn't
2017-01-27 20:46 octopus merge --no-ff claims to fast-forward even though it doesn't Samuel Lijin
@ 2017-01-27 21:59 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2017-01-27 21:59 UTC (permalink / raw)
To: Samuel Lijin; +Cc: git
Samuel Lijin <sxlijin@gmail.com> writes:
> I was doing an octopus merge earlier and noticed that it claims to
> fast-forward when you specify --no-ff, even though it does actually
> abide by --no-ff.
This was intentional and hasn't changed since it was first designed;
the octopus was to be used only for the simple and obvious merges.
If anything, I think it should error out when the --no-ff option is
given, issuing the same error message as the one given when any step
other than the last one needs manual resolution.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-27 22:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-27 20:46 octopus merge --no-ff claims to fast-forward even though it doesn't Samuel Lijin
2017-01-27 21:59 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).