Bash prompt "namespace" issue

Bash prompt "namespace" issue

[szeder]

Hi,

Commit 59d3924fb (prompt: fix missing file errors in zsh) added the  
helper function eread() to git-prompt.sh.  That function should be in  
the git "namespace", i.e. prefixed with __git_, otherwise it might  
collide with a function of the same name in the user's environment.

It's already in master and I don't have the means to send a patch  
fixing this ATM, sorry.

Best,
Gábor

Re: Bash prompt "namespace" issue

[Junio C Hamano]

szeder@ira.uka.de writes:

> Commit 59d3924fb (prompt: fix missing file errors in zsh) added the  
> helper function eread() to git-prompt.sh.  That function should be in  
> the git "namespace", i.e. prefixed with __git_, otherwise it might  
> collide with a function of the same name in the user's environment.
>
> It's already in master and I don't have the means to send a patch  
> fixing this ATM, sorry.

Thanks.  I think the patch Felipe posted to rename it to __git_eread
is a reasonable regression fix, so I'll queue it on top of the
problematic commit 59d3924f (prompt: fix missing file errors in zsh,
2014-04-11) and merge the result to 'master'.