archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <>
To: "Ævar Arnfjörð Bjarmason" <>
Cc:, Jeff King <>
Subject: Re: What's cooking in git.git (Mar 2021, #07; Mon, 22)
Date: Tue, 30 Mar 2021 17:20:38 -0700	[thread overview]
Message-ID: <xmqqr1jw897t.fsf@gitster.g> (raw)
In-Reply-To: <> (=?utf-8?B?IsOGdmFyIEFy?= =?utf-8?B?bmZqw7Zyw7A=?= Bjarmason"'s message of "Sun, 28 Mar 2021 15:50:20 +0200")

Ævar Arnfjörð Bjarmason <> writes:

>> * ab/pickaxe-pcre2 (2021-02-18) 24 commits
>>  - pickaxe -G: don't special-case create/delete
>>  - pickaxe -G: terminate early on matching lines
>>  - xdiff-interface: support early exit in xdiff_outf()
>>  - xdiff-interface: allow early return from xdiff_emit_{line,hunk}_fn
>>  - pickaxe -S: slightly optimize contains()
>>  - pickaxe: rename variables in has_changes() for brevity
>>  - pickaxe -S: support content with NULs under --pickaxe-regex
>>  - pickaxe: assert that we must have a needle under -G or -S
>>  - pickaxe: refactor function selection in diffcore-pickaxe()
>>  - perf: add performance test for pickaxe
>>  - pickaxe/style: consolidate declarations and assignments
>>  - diff.h: move pickaxe fields together again
>>  - pickaxe: die when --find-object and --pickaxe-all are combined
>>  - pickaxe: die when -G and --pickaxe-regex are combined
>>  - pickaxe tests: test for -G, -S and --find-object incompatibility
>>  - pickaxe tests: add test for "log -S" not being a regex
>>  - pickaxe tests: add test for diffgrep_consume() internals
>>  - pickaxe tests: refactor to use test_commit --append --printf
>>  - test-lib functions: add --printf option to test_commit
>>  - test-lib-functions: reword "test_commit --append" docs
>>  - test-lib-functions: document and test test_commit --no-tag
>>  - grep/pcre2 tests: reword comments referring to kwset
>>  - Merge branch 'jk/rev-list-disk-usage' into ab/pickaxe-pcre2
>>  - Merge branch 'ab/test-lib' into ab/pickaxe-pcre2
>>  Rewrite the backend for "diff -G/-S" to use pcre2 engine when
>>  available.
>>  Ready???
> I think it's been ready for while, but unfortunately it hasn't gotten
> much/any review.
> The changes to the C code are all rather trivial (just the "change
> return; to return 0" is rather verbose). 

It is a shame that this series hasn't seen any reviews.  It had so
many low-hanging crufts to be pointed out, netting aspiring reviewer
some "review points" ;-)

I think a change to tolerate -G with --pickaxe-regex combination (as
the latter becomes a redundant no-op in today's world because -G
cannot do fixed strings), instead of marking them incompatible, may
require the "function selection" step to be rewritten, but other
than that, I didn't see much that is fundamentally objectionable.

The summary I wrote in the "What's cooking" report was not quite
right, by the way.  There is nothing pcre2 yet in these patches.
They are preliminary clean-ups only.


      parent reply	other threads:[~2021-03-31  0:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  3:47 What's cooking in git.git (Mar 2021, #07; Mon, 22) Junio C Hamano
2021-03-24 10:43 ` ag/merge-strategies-in-c, was " Johannes Schindelin
2021-03-24 17:13   ` Junio C Hamano
2021-03-28 13:50 ` Ævar Arnfjörð Bjarmason
2021-03-28 18:33   ` Junio C Hamano
2021-03-31  0:20   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr1jw897t.fsf@gitster.g \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).